Skip to content

Don't escape special chars when they are in inline_code #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Don't escape special chars when they are in inline_code #743

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/github_changelog_generator/generator/section.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,10 @@ def encapsulate_string(string)
string = string.gsub('\\', '\\\\')

ENCAPSULATED_CHARACTERS.each do |char|
string = string.gsub(char, "\\#{char}")
# Only replace char with escaped version if it isn't inside backticks (markdown inline code).
# This relies on each opening '`' being closed (ie an even number in total).
# A char is *outside* backticks if there is an even number of backticks following it.
string = string.gsub(%r{#{Regexp.escape(char)}(?=([^`]*`[^`]*`)*[^`]*$)}, "\\#{char}")
end

string
Expand Down