Update #get_all_tags to only return tags that are for commits on the current branch's history #770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fe9bed8 to
cc03887
Compare
cc03887 to
d687658
Compare
|
Would it be possible to have a review of this? The issue that it resolves is a blocker for me being able to use the officially published gem and I think that it's a legitimate bug in the handling of orphan branches. |
26266c0 to
6f5460d
Compare
|
Would be great to get this merged. We've tested the branch and it works. This is affecting us as well. Thank you! |
6f5460d to
b07c771
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've encountered a scenario where my repository has multiple branches for different versions of the library. Each major version has a branch that started off as an orphan branch.
This causes issues for me when generating the change log because the
Full Changeloglinks sometimes reference a tag from the 2.x branch when I'm generating the change log for the 3.x branch.This PR addresses that issue by modifying the
#get_all_tagsmethod to only include tags that are for commits that exist in the current branch's commits.