Skip to content

fix: disable preview api warning from octokit.rb #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2020

Conversation

digglife
Copy link
Contributor

@digglife digglife commented Apr 2, 2020

octokit outputs warning message for preview API such as issue_events,
which is annoying. We can explicitly add the accept option when
calling the API to disable it.

Refer to lib/octokit/preview.rb in octokit for more information.

fix: #773

octokit outputs warning message for preview API such as `issue_events`,
which is annoying. We can explicitly add the accept option when
calling the API to disable it.

Refer to `lib/octokit/preview.rb` in octokit for more information.

fix: github-changelog-generator#773
@skywinder
Copy link
Member

Thank you very much, @digglife ! Much appreciated!

ps.
BTW, I would like to support from Tidelift this project. (about 50$/month) - I would be glad to send this money to supporters.
If you would like to help with resolving issues and PR - please send me a message, we can discuss this option.

@skywinder skywinder changed the base branch from master to develop April 5, 2020 17:41
@skywinder skywinder merged commit 64cbd74 into github-changelog-generator:develop Apr 5, 2020
@digglife
Copy link
Contributor Author

digglife commented Apr 6, 2020

@skywinder

Cool! I'm glad to be a maintainer.

@skywinder
Copy link
Member

@digglife SOunds awesome! I sent you email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning about Project_card_events API
2 participants