Skip to content

Section: Split quicker on newline #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2020
Merged

Section: Split quicker on newline #791

merged 1 commit into from
Apr 12, 2020

Conversation

olleolleolle
Copy link
Collaborator

This PR adds "split into 2 groups" to a string-splitting method:

  • we only need to get 1 group
  • so we can ask String#split() to give us two groups

@olleolleolle
Section: Split quicker on newline
9d334d1 
  - we only need to get 1 group
  - so we can ask String#split() to give us two groups
@olleolleolle olleolleolle merged commit 890cdb3 into master Apr 12, 2020
@olleolleolle olleolleolle deleted the quicker-to-split-into-2-groups branch April 12, 2020 21:20
@weekly-digest weekly-digest bot mentioned this pull request Apr 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferrarimarco ferrarimarco ferrarimarco approved these changes

Assignees

@olleolleolle olleolleolle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olleolleolle @ferrarimarco