Fix replicating template messages #794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Header, footer and '\n' will be treated correctly Issue: #787 - Stop generating headers and footers indefinitely, leaving only one right each time. - To find the exact same string as the key, the Regex key must be escaped with Regex.escape(). - First I have been fixing only credit_line, but this framework should be applied not only to credit_line but also to header and frontmatter, so I changed header and frontmatter to be deleted once. - Automatically remove only the automatically added '\n' and not remove any additional '\n' that may have been added manually by the user. - specs for this issue is prepared.
|
Thanks for this! I'll review soon. 👍 |
olleolleolle
requested changes
Apr 14, 2020
newer YARD style Co-Authored-By: Olle Jonsson <olle.jonsson@gmail.com>
Content of comment text Co-Authored-By: Olle Jonsson <olle.jonsson@gmail.com>
Modified require statements which are automatically added by "rspec-kickstarter" Co-Authored-By: Olle Jonsson <olle.jonsson@gmail.com>
an empty line before expect statement Co-Authored-By: Olle Jonsson <olle.jonsson@gmail.com>
an empty line before expect statement Co-Authored-By: Olle Jonsson <olle.jonsson@gmail.com>
|
I pressed all "Commit suggestion"s by @olleolleolle. |
olleolleolle
approved these changes
Apr 15, 2020
There was a problem hiding this comment.
Alright! Thanks again @shinyaohtani for fixing this issue! ✨
Let's get this merged.
|
@olleolleolle |
|
@olleolleolle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #787
Header, footer and '\n' will be treated correctly