Skip to content

Append issues omitted in next accepted release (by rules) #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Append issues omitted in next accepted release (by rules) #889

wants to merge 5 commits into from

Conversation

dlanileonardo
Copy link
Collaborator

@dlanileonardo dlanileonardo commented Aug 11, 2020 •
edited
Loading

Hi Friends! 😃

I observed a problem, I will explain.

When I have this scenario:

Tags:

  • 2.0.0-rc
  • 2.0.0-pre
  • 1.9.2-rc
  • 1.9.2-pre

And I use this config:

exclude-tags-regex=.*-pre

I expect something like that:

# CHANGELOG.md
## [2.0.0-rc](https://github.com/user/repo/tree/2.0.0-rc) (0000-00-00)
[Full Changelog](https://github.com/achievemore/achievemore-flutter/compare/1.9.2-rc...2.0.0-rc)

- Task 1
- Task 2
- Task 3

## [1.9.2-rc](https://github.com/user/repo/tree/1.9.2-rc) (0000-00-00)
[Full Changelog](https://github.com/achievemore/achievemore-flutter/compare/ee23bc22d78c00...1.9.2-rc)

- Task 4
- Task 5
- Task 6

But currently I obtain:

# CHANGELOG.md
## [2.0.0-rc](https://github.com/user/repo/tree/2.0.0-rc) (0000-00-00)
[Full Changelog](https://github.com/achievemore/achievemore-flutter/compare/2.0.0-pre...2.0.0-rc)

- Task 1

## [1.9.2-rc](https://github.com/user/repo/tree/1.9.2-rc) (0000-00-00)
[Full Changelog](https://github.com/achievemore/achievemore-flutter/compare/1.9.2-pre...1.9.2-rc)

- Task 4

Some issues are omitted, because the rejected tags are been used to compare (diff) old and new tag in generate_entries_for_all_tags method.

And compare link with excluded tags, this no make sense for me.

I think this solve this problem #842.

I created append_excluded option, i dont know if this is better name, just let me know what you think about this. 🙏

@skywinder
Copy link
Member

@dlanileonardo sorry for being silence. I'm working on other projects now. I'm highly appreciate help to support this library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dlanileonardo @skywinder