Skip to content

When tags are excluded, do not include those tags in diff links. #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 1, 2021
Merged

When tags are excluded, do not include those tags in diff links. #930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c83cbb
When tags are excluded, do not include those tags in diff links.
ameir Jan 15, 2021
64fc672
Merge branch 'master' into changelog-links-fix
olleolleolle Jan 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions lib/github_changelog_generator/generator/generator_tags.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,7 @@ def fetch_and_filter_tags
@sorted_tags = filter_included_tags(all_sorted_tags)
@sorted_tags = filter_excluded_tags(@sorted_tags)
@filtered_tags = get_filtered_tags(@sorted_tags)

# Because we need to properly create compare links, we need a sorted list
# of all filtered tags (including the excluded ones). We'll exclude those
# tags from section headers inside the mapping function.
section_tags = get_filtered_tags(all_sorted_tags)

@tag_section_mapping = build_tag_section_mapping(section_tags, @filtered_tags)
@tag_section_mapping = build_tag_section_mapping(@filtered_tags, @filtered_tags)

@filtered_tags
end
Expand Down
6 changes: 3 additions & 3 deletions spec/unit/generator/generator_tags_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,10 @@ def tags_from_strings(tags_strings)
shared_examples_for "a changelog with some exclusions" do
let(:expected_mapping) do
{
tag_with_name("8") => [tag_with_name("7"), tag_with_name("8")],
tag_with_name("6") => [tag_with_name("5"), tag_with_name("6")],
tag_with_name("8") => [tag_with_name("6"), tag_with_name("8")],
tag_with_name("6") => [tag_with_name("4"), tag_with_name("6")],
tag_with_name("4") => [tag_with_name("3"), tag_with_name("4")],
tag_with_name("3") => [tag_with_name("2"), tag_with_name("3")],
tag_with_name("3") => [tag_with_name("1"), tag_with_name("3")],
tag_with_name("1") => [nil, tag_with_name("1")]
}
end
Expand Down