Skip to content

Restoring tag hash references to string keys #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2021
Merged

Restoring tag hash references to string keys #937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/github_changelog_generator/octo_fetcher.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ def commits_in_branch(name)
def fetch_tag_shas(tags)
# Reverse the tags array to gain max benefit from the @commits_in_tag_cache
tags.reverse_each do |tag|
tag["shas_in_tag"] = commits_in_tag(tag[:commit][:sha])
tag["shas_in_tag"] = commits_in_tag(tag["commit"]["sha"])
end
end

Expand Down
6 changes: 3 additions & 3 deletions spec/unit/octo_fetcher_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,9 @@
]
end

let(:tag0) { { name: "tag-0", commit: { sha: "0" } } }
let(:tag1) { { name: "tag-1", commit: { sha: "1" } } }
let(:tag6) { { name: "tag-6", commit: { sha: "6" } } }
let(:tag0) { { "name" => "tag-0", "commit" => { "sha" => "0" } } }
let(:tag1) { { "name" => "tag-1", "commit" => { "sha" => "1" } } }
let(:tag6) { { "name" => "tag-6", "commit" => { "sha" => "6" } } }

before do
allow(fetcher).to receive(:commits).and_return(commits)
Expand Down