Skip to content

Ruby 3 support #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed

Conversation

cormacrelf
Copy link

@cormacrelf
Copy link
Author

Ah whoops, can't believe I wasted time on this when #949 already exists!

@cormacrelf cormacrelf closed this Apr 6, 2021
@cormacrelf
Copy link
Author

While I'm here I can report that I updated the GitHub API VCR cassettes and tried out using actual pull_request objects for pull requests instead of issues. The merge_commit_sha turns out to be less useful than the comment in generator_fetcher.rb anticipated, as for example with https://github.com/github-changelog-generator/changelog_test/pulls/2 the merge_commit_sha points to a commit that no longer exists and this produces incorrect results in various ways. So using the attached events is superior. Hope that helps.

@olleolleolle
Copy link
Collaborator

@cormacrelf If you want to, you can propose a PR, collecting those thoughts into something everyone can read. I'm only the care-taker.

@cormacrelf
Copy link
Author

@olleolleolle it would just be a PR updating a comment, but sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants