Skip to content

Fix: always return an Array from #commits_in_branch #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2021
Merged

Fix: always return an Array from #commits_in_branch #957

merged 1 commit into from
Apr 28, 2021

Conversation

olleolleolle
Copy link
Collaborator

@olleolleolle olleolleolle commented Apr 28, 2021 •
edited
Loading

The problem was that a method which would return a list could return nil instead of the empty list. This PR changes that to always return a list.

This commit also refactors the name of a method to reflect that it is a
predicate method.

Also: a YARD annotation, using the built-in 'void' type.

Fixes #954

@olleolleolle
Fix: always return an Array from #commits_in_branch
989812b 
This commit also refactors the name of a method to reflect that it is a
predicate method.

Also: a YARD annotation, using the built-in 'void' type.

Fixes #954
@olleolleolle olleolleolle merged commit c596513 into master Apr 28, 2021
@olleolleolle olleolleolle deleted the fix-nomethod-error-954 branch April 28, 2021 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to run, undefined method `include?' for nil:NilClass (NoMethodError)
1 participant
@olleolleolle