Skip to content

Updated markdown GFM test. #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2019
Merged

Conversation

j-rewerts
Copy link
Member

As an alternative to PR #501. I'm not sure if the response just changed within the past few days.

I think if we merge this in, and #544 , then tests will be passing.

@j-rewerts
Copy link
Member Author

Also, if @DanielRuf updates their test, feel free to close this PR in lieu of that one.

@DanielRuf
Copy link

It seems there were also other changes or the API had issues.

https://travis-ci.org/github-tools/github/builds/516385114

@j-rewerts
Copy link
Member Author

Yeah that should be covered in #544. If both are merged, I think the test suite passes.

@j-rewerts j-rewerts mentioned this pull request Apr 6, 2019
Copy link
Member

@clayreimann clayreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failed on outdated node versions

@clayreimann clayreimann merged commit dcc3472 into github-tools:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants