Skip to content

Add commit author #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 10, 2019
Merged

Add commit author #547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d68aab6
Added test for commit.
j-rewerts Apr 5, 2019
c2d279c
Created test for commit author change.
j-rewerts Apr 6, 2019
09f2042
Added optional options to commit.
j-rewerts Apr 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion lib/Repository.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,16 +334,26 @@ class Repository extends Requestable {
* @param {string} parent - the SHA of the parent commit
* @param {string} tree - the SHA of the tree for this commit
* @param {string} message - the commit message
* @param {Object} [options] - commit options
* @param {Object} [options.author] - the author of the commit
* @param {Object} [options.commiter] - the committer
* @param {Requestable.callback} cb - will receive the commit that is created
* @return {Promise} - the promise for the http request
*/
commit(parent, tree, message, cb) {
commit(parent, tree, message, options, cb) {
if (typeof options === 'function') {
cb = options;
options = {};
}

let data = {
message,
tree,
parents: [parent],
};

data = Object.assign({}, options, data);

return this._request('POST', `/repos/${this.__fullname}/git/commits`, data, cb)
.then((response) => {
this.__currentTree.sha = response.data.sha; // Update latest commit
Expand Down
39 changes: 39 additions & 0 deletions test/repository.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,6 +600,45 @@ describe('Repository', function() {
}));
});

it('should succeed on proper commit', function(done) {
let parentSHA = '';
let treeSHA = '';
remoteRepo.getRef('heads/master').then((ref) => {
parentSHA = ref.data.object.sha;
return remoteRepo.getCommit(parentSHA);
}).then((commit) => {
treeSHA = commit.data.tree.sha;
return remoteRepo.commit(parentSHA, treeSHA, 'is this thing on?');
}).then((commit) => {
expect(commit.data.author).to.have.own('name', 'Mike de Boer');
expect(commit.data.author).to.have.own('email', 'mike@c9.io');
done();
});
});

it('should allow commit to change author', function(done) {
let parentSHA = '';
let treeSHA = '';
remoteRepo.getRef('heads/master').then((ref) => {
parentSHA = ref.data.object.sha;
return remoteRepo.getCommit(parentSHA);
}).then((commit) => {
treeSHA = commit.data.tree.sha;
return remoteRepo.commit(parentSHA, treeSHA, 'Who made this commit?', {
author: {
name: 'Jimothy Halpert',
email: 'jim@dundermifflin.com',
},
});
}).then((commit) => {
expect(commit.data.author).to.have.own('name', 'Jimothy Halpert');
expect(commit.data.author).to.have.own('email', 'jim@dundermifflin.com');
done();
}).catch((err) => {
throw err;
});
});

it('should create a release', function(done) {
const releaseDef = {
name: releaseName,
Expand Down