#569 tamer1an fix for get all pages in _requestAllPages #575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-tools#569 _requestAllPages parse options.page from nextUrl
github-tools#569 clean up
j-rewerts
requested changes
Aug 1, 2019
| log(`getting next page: ${nextUrl}`); | ||
| return this._requestAllPages(nextUrl, options, cb, results); | ||
| if(nextUrl) { | ||
| options.page = parseInt( |
There was a problem hiding this comment.
It's possible for options to be undefined. Please handle this prior to setting page.
lib/Requestable.js
Outdated
| return this._requestAllPages(nextUrl, options, cb, results); | ||
| if(nextUrl) { | ||
| options.page = parseInt( | ||
| nextUrl.match(/(&page=[0-9]*)/g) |
There was a problem hiding this comment.
This only matches against the page having a parameter before it. Something like this would break it:
https://api.github.com/organizations/17532995/teams?page=2Is there a reason we need to match against the &?
There was a problem hiding this comment.
ok will double check
|
Congratz with a new version 💪 Thanks for help with PR @j-rewerts 💚 I almost introduced that fix with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing for #569 _requestAllPages
#569