Finish typing object, improve verious other types. #1279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The work you are doing here is monumental and I am impressed by the consistency with which you chip off little pieces one by one until the mountain is gone. I also hope that when it's all done you will be open to become a maintainer to keep GitPython operational, I have a feeling that I won't be able to do it in case something breaks when new versions of something break backwards compatibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one finished adding types to tree.py so objects folder is done.
Also:
-Add Typedict import and used to improve some Dict types.
-Add Typeguard (Pep647) and start to replace cast() and type: ignores with runtime checks and type narrowing.
-Change typing-extentions dependancy to <py3.10, for Typeguard
-Make IterableList generic and fix all uses to be IterableList[Iterable-type], e.g. IterableList[Head]
-Rename Iterable to IterableObj and changed throughout, due to naming conflic with typing.Iterable. I left git.util.Iterable in place for now and added a deprecationwarning in case users are using it themselves for some reason.
Ready to merge