Skip to content

is_dirty supports path. Fixes #482. #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2016

Conversation

haizaar
Copy link
Contributor

@haizaar haizaar commented Aug 1, 2016

No description provided.

@haizaar haizaar mentioned this pull request Aug 1, 2016
@Byron Byron added this to the v2.0.8 - Bugfixes milestone Aug 2, 2016
@Byron
Copy link
Member

Byron commented Aug 2, 2016

@haizaar Thanks a lot ! The PR already looks good to me. The only thing I was wondering is whether we should start supporting multiple paths right away. It's just that git status already does that, at least when looking at it's usage spec:

git status [<options>...] [--] [<pathspec>...]

What do you think ?

@haizaar
Copy link
Contributor Author

haizaar commented Aug 2, 2016

Hi Sebastian,

I would rather wait until someone requests it. Particularly, because the
project is in maintenance mode, we better only add features that are driven
by user demand.

path argument can be extended in the future to accept list of paths as
well.

On 2 Aug 2016 06:57, "Sebastian Thiel" notifications@github.com wrote:

@haizaar https://github.com/haizaar Thanks a lot ! The PR already looks
good to me. The only thing I was wondering is whether we should start
supporting multiple paths right away. It's just that git status already
does that, at least when looking at it's usage spec:

git status [...] [--] [...]

What do you think ?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#496 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADjWaSZizeq8Q0_c595kKwnpePfrwEIks5qbsAYgaJpZM4JZf5s
.

@Byron Byron merged commit e866c4a into gitpython-developers:master Aug 2, 2016
@Byron
Copy link
Member

Byron commented Aug 2, 2016

Thanks for your contribution, it's much appreciated !

@haizaar
Copy link
Contributor Author

haizaar commented Aug 2, 2016

Thanks. When do you plan a new PyPi release?

On 2 Aug 2016 8:54 AM, "Sebastian Thiel" notifications@github.com wrote:

Thanks for your contribution, it's much appreciated !


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#496 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADjWSCEaAlx34gTcsrKyVRRwXM5adVXks5qbtuGgaJpZM4JZf5s
.

@Byron
Copy link
Member

Byron commented Aug 3, 2016

v2.0.8 was just released to pypi.

@haizaar
Copy link
Contributor Author

haizaar commented Aug 3, 2016

Thank you!

On 3 Aug 2016 07:50, "Sebastian Thiel" notifications@github.com wrote:

v2.0.8 was just released to pypi.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#496 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADjWVPxlHc9CMVep2dLBP6eCJo8JrB6ks5qcB4fgaJpZM4JZf5s
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants