BF: install_requires not just requires for setup() call #873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally detected while running DataLad tests on CRON datalad/datalad#3395
Codecov Report
@@ Coverage Diff @@
## master #873 +/- ##
=======================================
Coverage 94.79% 94.79%
=======================================
Files 59 59
Lines 9607 9607
=======================================
Hits 9107 9107
Misses 500 500Continue to review full report at Codecov.
|
|
I think this one is obvious so I will just merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally detected while running DataLad tests on CRON datalad/datalad#3395 although mystery remains why not earlier.
To say the truth I am not fan of the approach (defer to reading requirements.txt) introduced in ce21f63 but I guess it is a separate issue