Skip to content

gitattributes.ReadAttributesFile does not close file #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
prskr opened this issue Feb 2, 2024 · 0 comments
Closed

gitattributes.ReadAttributesFile does not close file #1017

prskr opened this issue Feb 2, 2024 · 0 comments

Comments

@prskr
Copy link
Contributor

prskr commented Feb 2, 2024

Hi all,

first of all, thank you so much for providing us with this awesome library!

I noticed that gitattributes.ReadAttributesFile(...) does not properly close the file after successfully opening it.
Although that is not an issue on Linux/MacOS it breaks my CI on Windows when trying to clean a temp directory although a .gitattributes file is not closed.

I will provide a PR in a moment to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant