Skip to content

Support for SHA256 #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
3 of 11 tasks
pjbgf opened this issue Mar 7, 2023 · 7 comments
Open
3 of 11 tasks

Support for SHA256 #706

pjbgf opened this issue Mar 7, 2023 · 7 comments
Assignees
@pjbgf
Milestone
v6.0.0

Comments

@pjbgf
Copy link
Member

pjbgf commented Mar 7, 2023 •
edited
Loading

Implement SHA256 support as per https://git-scm.com/docs/hash-function-transition/.

High level changes:

  • Repository Format Extension
  • Init a valid SHA256 repository
  • Packfile
  • Loose object index
  • Bidirectional (SHA-1 <-> SHA-256) mapping table
  • Fetching from SHA1 server
  • Signed Commits
  • Signed Tags
  • Mergetag
  • Submodules
  • Shallow clone (unsupported - fail gracefully)
@pjbgf pjbgf self-assigned this Mar 7, 2023
pjbgf added a commit to pjbgf/go-git that referenced this issue Mar 7, 2023
@pjbgf
plumbing/hash: Add SHA256 as a supported algorithm
0249421 
Relates to go-git#706.

Signed-off-by: Paulo Gomes <pjbgf@linux.com>
pjbgf added a commit to pjbgf/go-git that referenced this issue Mar 8, 2023
@pjbgf
config: Add Repository Format Extension
99e2f85 
Relates to the SHA256 implementation, defined in go-git#706.

Signed-off-by: Paulo Gomes <pjbgf@linux.com>
pjbgf added a commit to pjbgf/go-git that referenced this issue Mar 8, 2023
@pjbgf
*: Support variable length plumbing.Hash
9822ad8 
The variable length for plumbing.Hash is defined at build time, blocked by
tag sha256.

This approach was a trade-off between keeping backwards compatibility while
making progress towards supporting SHA256 with a small amount of changes.

Relates to the SHA256 implementation, defined in go-git#706.

Signed-off-by: Paulo Gomes <pjbgf@linux.com>
pjbgf added a commit to pjbgf/go-git that referenced this issue Mar 8, 2023
@pjbgf
examples: Add example for SHA256 repositories
8e82810 
Add a new example on initializing a new repository with object format SHA256.
A new Makefile target was created to run the example to ensure that new changes
won't break SHA256 support going forwards.

Relates to the SHA256 implementation, defined in go-git#706.

Signed-off-by: Paulo Gomes <pjbgf@linux.com>
@pjbgf pjbgf mentioned this issue Mar 8, 2023
Merged
@AdamMajer
Copy link

Thanks for working on this. I think the transition doesn't yet need to be implemented, since it doesn't really work in git tools anyway. What should be implemented is simply ability to work with SHA256 repositories - I think this is the scope of the work here.

SHA1 <> SHA256 repo interop probably will need some more thought and implementation upstream first.

@AdamMajer
Copy link

Seems a duplicate of #229 although more work is done here so maybe close the other issue.

@pjbgf pjbgf mentioned this issue Apr 18, 2023
Closed
@pjbgf
Copy link
Member Author

pjbgf commented Apr 18, 2023

@AdamMajer thanks for calling out the duplicated issue - just closed it.

I agree with your comment on the transition. Given that go-git aims to be aligned with upstream, the items pending for SHA256 will always have a hard blocker in terms of whether or not upstream already merged the given feature/change.

#707 Already added support to create and make commits in SHA256 repositories, but this is still experimental - hence why it is blocked by a build tag.

@AdamMajer
Copy link

@pjbgf , just to make sure I'm reading the patch you linked correctly, this basically just allows go-git to use only sha256 or sha1, depending on the build tag? There is no possibility of using both hash types in one program?

@pjbgf
Copy link
Member Author

pjbgf commented Jun 27, 2023 •
edited
Loading

@AdamMajer that's correct. That is a temporary limitation which aims to keep backwards compatibility with the API - as plumbing.Hash defines the hash's length. There are also some performance/memory footprint considerations that will need to be considered when we implement that.

Once the bilateral mapping table is implemented, we should start looking into removing that limitation.

durandj pushed a commit to durandj/go-git that referenced this issue Jul 1, 2023
@pjbgf @durandj
plumbing/hash: Add SHA256 as a supported algorithm
d7d63c0 
Relates to go-git#706.

Signed-off-by: Paulo Gomes <pjbgf@linux.com>
durandj pushed a commit to durandj/go-git that referenced this issue Jul 1, 2023
@pjbgf @durandj
config: Add Repository Format Extension
025b721 
Relates to the SHA256 implementation, defined in go-git#706.

Signed-off-by: Paulo Gomes <pjbgf@linux.com>
durandj pushed a commit to durandj/go-git that referenced this issue Jul 1, 2023
@pjbgf @durandj
*: Support variable length plumbing.Hash
715924c 
The variable length for plumbing.Hash is defined at build time, blocked by
tag sha256.

This approach was a trade-off between keeping backwards compatibility while
making progress towards supporting SHA256 with a small amount of changes.

Relates to the SHA256 implementation, defined in go-git#706.

Signed-off-by: Paulo Gomes <pjbgf@linux.com>
durandj pushed a commit to durandj/go-git that referenced this issue Jul 1, 2023
@pjbgf @durandj
examples: Add example for SHA256 repositories
8fd9251 
Add a new example on initializing a new repository with object format SHA256.
A new Makefile target was created to run the example to ensure that new changes
won't break SHA256 support going forwards.

Relates to the SHA256 implementation, defined in go-git#706.

Signed-off-by: Paulo Gomes <pjbgf@linux.com>
@pjbgf pjbgf mentioned this issue Oct 1, 2023
Merged
@6543 6543 mentioned this issue Oct 31, 2023
Open
@pjbgf pjbgf mentioned this issue Nov 7, 2023
Open
13 tasks
@AdamMajer AdamMajer mentioned this issue Jan 19, 2024
Merged
@codablock codablock mentioned this issue Oct 14, 2024
Open
traidare pushed a commit to traidare/go-git that referenced this issue Oct 26, 2024
@pjbgf
plumbing/hash: Add SHA256 as a supported algorithm
8c808c3 
Relates to go-git#706.

Signed-off-by: Paulo Gomes <pjbgf@linux.com>
traidare pushed a commit to traidare/go-git that referenced this issue Oct 26, 2024
@pjbgf
config: Add Repository Format Extension
cc260f1 
Relates to the SHA256 implementation, defined in go-git#706.

Signed-off-by: Paulo Gomes <pjbgf@linux.com>
traidare pushed a commit to traidare/go-git that referenced this issue Oct 26, 2024
@pjbgf
*: Support variable length plumbing.Hash
2d403a4 
The variable length for plumbing.Hash is defined at build time, blocked by
tag sha256.

This approach was a trade-off between keeping backwards compatibility while
making progress towards supporting SHA256 with a small amount of changes.

Relates to the SHA256 implementation, defined in go-git#706.

Signed-off-by: Paulo Gomes <pjbgf@linux.com>
traidare pushed a commit to traidare/go-git that referenced this issue Oct 26, 2024
@pjbgf
examples: Add example for SHA256 repositories
7ba9abc 
Add a new example on initializing a new repository with object format SHA256.
A new Makefile target was created to run the example to ensure that new changes
won't break SHA256 support going forwards.

Relates to the SHA256 implementation, defined in go-git#706.

Signed-off-by: Paulo Gomes <pjbgf@linux.com>
@gecube
Copy link

gecube commented Oct 30, 2024

Hi!

I am waiting for changes, as I just experienced that Gitlab.com offers the new SHA-256 algorithm, but unfortunately tools bases on go-git could not work with such a repos...

image

@pjbgf
Copy link
Member Author

pjbgf commented Oct 30, 2024 •
edited
Loading

@gecube thanks for the ping - I wasn't aware of that support from Gitlab. 🙇
The packfile refactoring is well under progress, hopefully by next month I will be able to get that merged against v6-exp - which should enable for cloning sha256 repositories.

@pjbgf pjbgf added this to the v6.0.0 milestone Jan 1, 2025
@pjbgf pjbgf mentioned this issue Jan 6, 2025
Merged
@juju4 juju4 mentioned this issue Mar 2, 2025
Closed
@lunny lunny mentioned this issue Mar 21, 2025
Open
@pjbgf pjbgf mentioned this issue Apr 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjbgf pjbgf

Labels
None yet
Projects
None yet
Milestone
v6.0.0
Development

No branches or pull requests
3 participants
@AdamMajer @gecube @pjbgf