plumbing: transport server check for nil Packfile, fixes ref deletes #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you provide a test for this? |
836e592 to
cec6ee3
Compare
|
@mcuadros added a test for this directly inside Also the force push is because I had branched from v4, so simply rebased in current v5 master for the PR. |
|
@mcuadros thanks! |
pjbgf
referenced
this pull request
in pjbgf/go-git
Dec 6, 2022
Return error instead of creating empty commits
traidare
pushed a commit
to traidare/go-git
that referenced
this pull request
Oct 26, 2024
…server plumbing: transport server check for nil Packfile, fixes ref deletes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
Remotereceives a push with only delete commands, it sends anilvalue forPackfile(related code), which results in a apanic: runtime error: invalid memory address or nil pointer dereferencein the code below. This simply fixes that by skipping the processing if itsnil.It does seem there is already a test case covering deletes inside the
ReceivePackSuite, however the test sends an empty packfile rather than sendingnil.If it would be better to update
Remoteto send a similar empty packfile please let me know and I'll be happy to make the update.Also thanks for all the work here, we've been using go-git heavily for the last few weeks and its fantastic.