refactor transport: plumbing: transport, refactor and define transport operations (2/5) #1337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15e2048 to
0f3b3ef
Compare
This was referenced Dec 31, 2024
0f3b3ef to
f077b31
Compare
pjbgf
reviewed
Jan 1, 2025
| @@ -0,0 +1,11 @@ | |||
| package transport | |||
There was a problem hiding this comment.
This change may break the fuzzing configuration in oss-fuzz. But we will look at that prior to converting the v6-exp into main.
| return "", err | ||
| // NewTransport returns a new file transport that users go-git built-in server | ||
| // implementation to serve repositories. | ||
| func NewTransport(loader transport.Loader) transport.Transport { |
There was a problem hiding this comment.
I'd rather we start leaning on the options pattern instead - as per recent packfile changes. But we can refine that at a later point, before the V6 is released.
| if c == nil { | ||
| c = &http.Client{ | ||
| Transport: http.DefaultTransport, | ||
| func NewTransport(opts *TransportOptions) transport.Transport { |
There was a problem hiding this comment.
Same about the use of options here, ideally they would follow the same approach as this. But we can do that as a follow-up change.
f077b31 to
2d37d80
Compare
This change redefines the transport package to be more modular and extensible. It redefines the `transport.Transport`, `transport.Session`, and `transport.Commander` and `transport.Command` interfaces. It also introduces a new `transport.Connection` that abstracts the logic of sending and receiving git data to and from a server. There are 2 main transports. The pack transport which is a full-duplex command based transport that uses `transport.PackSession`. And the other is the HTTP transport which is a half-duplex transport that uses `transport.HTTPSession`. All of file, git, and ssh transports use the pack transport. The rest of the abstractions are defined in `transport.NegotiatePack`, `transport.FetchPack`, `transport.UploadPack`, `transport.SendPack`, and `tansport.ReceivePack`. All of these static functions are used by the `transport.Connection` to send and receive data to and from a `storage.Storer` interface type. Reference: https://gist.github.com/aymanbagabas/1b5ccc265ee62dd574c62d378b4b57bb
We no longer need a separate package for the server protocol, as it is now implemented in the transport package.
It makes more sense to have this living in the transport package, as it is related to the transport layer.
2d37d80 to
95f4718
Compare
aymanbagabas
commented
Jan 1, 2025
| return "", err | ||
| // NewTransport returns a new file transport that users go-git built-in server | ||
| // implementation to serve repositories. | ||
| func NewTransport(loader transport.Loader) transport.Transport { |
| @@ -0,0 +1,11 @@ | |||
| package transport | |||
Co-authored-by: Paulo Gomes <paulo.gomes.uk@gmail.com> Update remote.go Co-authored-by: Paulo Gomes <paulo.gomes.uk@gmail.com>
a639d95 to
2279b8a
Compare
pjbgf
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change redefines the transport package to be more modular and
extensible. It redefines the
transport.Transport,transport.Session,and
transport.Commanderandtransport.Commandinterfaces. It alsointroduces a new
transport.Connectionthat abstracts the logic ofsending and receiving git data to and from a server.
There are 2 main transports. The pack transport which is a full-duplex
command based transport that uses
transport.PackSession. And the otheris the HTTP transport which is a half-duplex transport that uses
transport.HTTPSession. All of file, git, and ssh transports use thepack transport.
The rest of the abstractions are defined in
transport.NegotiatePack,transport.FetchPack,transport.UploadPack,transport.SendPack, andtansport.ReceivePack. All of these static functions are used by thetransport.Connectionto send and receive data to and from astorage.Storerinterface type.Reference: https://gist.github.com/aymanbagabas/1b5ccc265ee62dd574c62d378b4b57bb
Based on: #1303