refactor transport: plumbing: transport, support multi-ack and multi-ack-detailed capabilities (3/5) #1338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
b062e53 to
90bdb93
Compare
…ities This adds support for multi-ack and multi-ack-detailed capabilities in the transport package. The support includes both the client and server. Related: go-git@2ebd65f Related: go-git#1204
90bdb93 to
14eabbd
Compare
pjbgf
reviewed
Jan 2, 2025
| r.ACKs = append(r.ACKs, h) | ||
| return nil | ||
| var ack ACK | ||
| // TODO: Dynamic hash size and sha256 support |
There was a problem hiding this comment.
Again, let's pick up on a future PR, but for packfile this is based on an "option" as the packfile can do SHA1 or SHA1 and SHA256 hashes. Here, I believe it would need to be either/or and would be based off the object format.
There was a problem hiding this comment.
Right, we will need to support the object-format capability. I think here, instead of hard-coding the hash lengths, we need to be more lenient and just treat whatever argument as a hash.
Co-authored-by: Paulo Gomes <paulo.gomes.uk@gmail.com>
pjbgf
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for multi-ack and multi-ack-detailed capabilities in
the transport package. The support includes both the client and server.
This works by properly implementing the negotiation algorithm where the client and server can send/receive multiple upload-haves and server-response requests. The implementation follows canonical git sending 32 have lines per compute step to find the optimal packfile.
Related: 2ebd65f
Related: #1204
Based on: #1303 and #1337