feat(plumbing/format/pktline): add DelimPkt and ResponseEndPkt support (protocol v2) #1345
+37
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bored-engineer Thank you for the PR. V2 wire protocol progress is being tracked in https://github.com/go-git/go-git/tree/v6-exp and https://github.com/go-git/go-git/tree/v6-transport. See https://github.com/go-git/go-git/blob/v6-transport/plumbing/format/pktline/common.go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Git's v2 wire protocol defines a few special packets in addition to the existing
flush-pkt:This PR adds support for reading and writing the
delim-pktandresponse-end-pktwithin the existingplumbing/format/pktlinepackage.The behavior is kept the same as
flush-pktwhereBytesreturns an empty slice when these are encountered, but now the "type" of that packet can be determined via theFlushPkt,DelimPkt,ResponseEndPktmethods which return true/false.