git: fetch and clone --filter support #1375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
91e9344 to
b7f12b9
Compare
pjbgf
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
@EarthCompass thank you for proposing this PR, this exposes the --filter feature, but due to the lack of partial clones support, it will result in a git repository that is not "fully operational" as a) we are not adding the metadata needed for git to know this is a partial clone and b) we are not handling missing objects.
IMO, that's OK, as this already enables traversing the Git metadata quite cheaply. It also enable users with Git knowledge to achieve optimal performance when using go-git.
Either way, I will create an issue to track partial clones support.
This was referenced Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Filter support for git clone and fetch. #713
I see an open PR #1108 that implemented this for fetch but was left open somehow. This is a more complete version of #1108.