-
Notifications
You must be signed in to change notification settings - Fork 787
Refactor transport tests #1450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor transport tests #1450
Conversation
3a6fc8e
to
7a34665
Compare
Even though the test doesn't support windows, I had to make it compilable for windows. I've manually tested it on my windows PC and it is properly killing daemon. go-git/plumbing/transport/git/common_test.go Lines 32 to 35 in f7eb53c
|
@onee-only thank you for looking into this. Please note that |
7a34665
to
eb61216
Compare
@pjbgf Thanks for telling me that I wasn't targeting the appropriate branch. I've rebased it to |
FYI, |
@onee-only apologies for the wasted effort here. @aymanbagabas have been working on several changes across transport, so making changes to tests that touch any of that is a bit problematic. Perhaps it is easier to just revisit this once #1496 is merged? |
I found out that #1496 introduces partial fix for #1445 by changing suites on About #1218, I didn't test it but fix for it also seems to be introduced in #1496. So I think I'll close this PR and make new one with small changes when #1496 is merged. |
@onee-only that sounds good, thanks for that. 🙇 |
Alright. closing the PR. |
This PR mainly introduces fixes for #1218 and #1445.
Other changes are minor enhancements for test code.