git: worktree, canonicalize pathnames when calling Worktree.Add(), Fixes #1460 #1491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Worktree.Add(), Fixes #1460
pjbgf
reviewed
Apr 13, 2025
8361313 to
4727c64
Compare
Worktree.Add(), Fixes #1460
0xDEC0DE
commented
Apr 14, 2025
go-git#1460 Ensure that adding files off the filesystem root gets the filenames right. Fixes: Issue go-git#1460
pjbgf
reviewed
Apr 26, 2025
Comment on lines
+376
to
+379
| if string(path[0]) == string(filepath.Separator) { | ||
| root := w.Filesystem.Root() | ||
| path, _ = filepath.Rel(root, filepath.Join(root, ".", path)) | ||
| } |
There was a problem hiding this comment.
Not entirely sure I understand, as the use case here is creating a new file; but there's already util.getUnderlyingAndPath, which I suppose could use an exported version, would that be sufficient for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that adding files off the filesystem root gets the filenames right.
Fixes: Issue #1460