[v5] plumbing: support mTLS for HTTPS protocol #1510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
hiddeco
commented
Apr 12, 2025
plumbing/transport/http/common.go
Outdated
| @@ -245,6 +263,8 @@ func newSession(c *client, ep *transport.Endpoint, auth transport.AuthMethod) (* | |||
| configureTransport(transport, ep) | |||
There was a problem hiding this comment.
Is the error swallowing here on purpose? It seems like this could result in unexpected behavior.
There was a problem hiding this comment.
I don't think so, we should at the very least log it. Do you mind handling the errors from the configureTransport calls into a separate commit please?
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
pjbgf
approved these changes
Apr 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for mTLS for the HTTPS protocol, the same way custom CA bundles were introduced for
v5. It is specifically targetingv5, as I believe inv6we may benefit from a full rehaul of how we work with transports (and may benefit from more fine-grainhttp.Transportinjection).