all: rm redundant dep and cleanup #1634
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes redundant dependencies and performs cleanup tasks across the codebase. The changes focus on modernizing code by removing deprecated imports and utilizing newer standard library features.
Key changes:
- Replaces deprecated
golang.org/x/net/contextwith standard librarycontextpackage - Removes unused
golang.org/x/expdependency and replacesmaps.Clearwith built-inclearfunction - Removes unused code including buffer pools, sideband functions, and error constants
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| utils/ioutil/context_test.go | Updates context import and improves string comparison efficiency |
| storage/filesystem/object.go | Removes unused copyBufferPool variable |
| remote.go | Removes unused sideband import and buildSidebandIfSupported function |
| plumbing/format/packfile/parser_cache.go | Replaces golang.org/x/exp/maps with built-in clear function |
| plumbing/format/packfile/packfile.go | Removes unused error constants and os import |
| go.mod | Removes golang.org/x/exp dependency |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@pjbgf hello! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.