-
Notifications
You must be signed in to change notification settings - Fork 788
Add Merge with ff-only #442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add a Merge function that behaves like git merge. This is a first iteration that only supports --ff-only, which is the simplest type of merge.
To others active in the repo could this be the start of implementing |
@sanderdekoning yes, that's the goal. I wanted to start out with the simplest version and then iterate forward. I think next would be implementing the non-ff 3-way merge |
@sanderdekoning yes, a review sounds like a good start. |
|
@mcuadros could you consider reviewing this PR? |
we would also very much appreciate a way of (at least) ff merging in the library. as we are implementing something for automatic merges during workflows and hate to escape from standard go implementation to command execution |
@pjbgf would you mind reviewing and merging this one as it's been around for quite some time? thank you! |
@john-cai I had a quick look on your PR and here's some initial feedback:
|
Hi, is possible to also include support for merging with -Xours and -Xtheirs? |
@john-cai are you still working on this? I might be interested in contributing to |
@patgmiller @john-cai I would like to see this happen too. I am happy to pledge my time to make this happen. |
Many people, including myself, are looking forward to the merge feature being implemented in go-git. |
Closing in favour of #1044. |
Add a Merge function that behaves like git merge. This is a first
iteration that only supports --ff-only, which is the simplest type of
merge.