Skip to content

Feature: Ephemeral action runners #33570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 47 commits into from
Mar 14, 2025
Merged

Feature: Ephemeral action runners #33570

merged 47 commits into from
Mar 14, 2025

Conversation

ChristopherHX
Copy link
Contributor

@ChristopherHX ChristopherHX commented Feb 12, 2025 •
edited
Loading

Closes #32461

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 12, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/migrations modifies/dependencies labels Feb 12, 2025
This was referenced Feb 23, 2025
Merged
Closed
@ChristopherHX
Copy link
Contributor Author

ChristopherHX commented Mar 12, 2025 •
edited
Loading

Hmm, what happens here removed test code in 8f79a8f? I currently have no idea what exactly is the cause, conflict of fixtures with data added in integration test? CleanupEphemeralRunner() is broken only for pgsql? There is an bug somewhere. (If this persists after the removal of added test data, then is CleanupEphemeralRunner defect)

--- FAIL: TestDownloadTaskLogs/test_.gitea/workflows/download-task-logs-zstd.yml (0.62s)
   actions_runner_test.go:106: 
       	Error Trace:	/home/runner/work/gitea/gitea/tests/integration/actions_runner_test.go:106
       	            				/home/runner/work/gitea/gitea/tests/integration/actions_log_test.go:126
       	Error:      	Received unexpected error:
       	            	unknown: rpc error: code = Internal desc = pick task: CreateTaskForRunner: pq: duplicate key value >violates unique constraint "UQE_action_task_step_task_index"
       	Test:       	TestDownloadTaskLogs/test_.gitea/workflows/download-task-logs-zstd.yml

EDIT

This is not a cause of my test. Does CleanupEphemeralRunner remove mock data? Need to look later

wxiaoguang
wxiaoguang approved these changes Mar 13, 2025
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 13, 2025
project-mirrors-bot-tu bot pushed a commit to project-mirrors/gitea-act-runner that referenced this pull request Mar 14, 2025
@ChristopherHX @lunny
ephemeral act runner (#649)
b1ae30d 
Works for both interactive and non-interactive registration mode.

A further enhancement would be jitconfig support of the daemon command, because after some changes in Gitea Actions the registration token became reusable.

removing runner and fail seems not possible at the current api level

Part of go-gitea/gitea#33570

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Reviewed-on: https://gitea.com/gitea/act_runner/pulls/649
Reviewed-by: Zettat123 <zettat123@noreply.gitea.com>
Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: Christopher Homberger <christopher.homberger@web.de>
Co-committed-by: Christopher Homberger <christopher.homberger@web.de>
@lunny lunny added this to the 1.24.0 milestone Mar 14, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 14, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 14, 2025
@GiteaBot
Copy link
Collaborator

@ChristopherHX please fix the merge conflicts. 🍵

@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 14, 2025
@ChristopherHX
Copy link
Contributor Author

please fix the merge conflicts. 🍵

False positive, nothing to merge and CI checks green.

@lunny lunny merged commit 65e2411 into go-gitea:main Mar 14, 2025
26 checks passed
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 17, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
a1c01b2 
* giteaofficial/main: (23 commits)
  [skip ci] Updated translations via Crowdin
  Update tool dependencies (go-gitea#33907)
  Move hooks function to gitrepo and reduce expose repopath (go-gitea#33890)
  Replace text-align classes with tailwind (go-gitea#33905)
  Simplify secure context check (go-gitea#33906)
  Update JS and PY deps, misc tweaks (go-gitea#33903)
  Refactor functions to reduce repopath expose (go-gitea#33892)
  Move git references checking to gitrepo packages to reduce expose of repository path (go-gitea#33891)
  [skip ci] Updated translations via Crowdin
  Add missing translation (go-gitea#33900)
  Give organisation members access to organisation feeds (go-gitea#33508)
  Add lock for a repository pull mirror (go-gitea#33876)
  Fix cannot delete runners via the modal dialog (go-gitea#33895)
  Add file tree to file view page (go-gitea#32721)
  [skip ci] Updated translations via Crowdin
  Feature: Ephemeral action runners (go-gitea#33570)
  Add abstraction layer to delete repository from disk (go-gitea#33879)
  Make SearchMode have default value and add comments (go-gitea#33863)
  Fix maven panic when no package exists (go-gitea#33888)
  Add old svg class name to git entry icon (go-gitea#33884)
  ...

# Conflicts:
#	templates/repo/wiki/revision.tmpl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/migrations
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

Register act_runner as ephemeral to Gitea
4 participants
@ChristopherHX @GiteaBot @lunny @wxiaoguang