Skip to content

Add Go module (#13) #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Conversation

M-Quadra
Copy link

@M-Quadra M-Quadra commented Jun 11, 2022

What does this PR do?

Add Go module.

Motivation

Dep is deprecated and archived in favor of Go modules.

Additional Notes

Remove the Dep files.

fixes #13

@christian-korneck
Copy link
Collaborator

@M-Quadra are you confident that this won’t be a breaking change for existing users? Are there edge cases in which it could be a breaking change (i.e. does it still work with dep , GOMODULE111=off go get, etc)?

@M-Quadra
Copy link
Author

Release policy of Go only supports two major version. There are 1.18 and 1.17 today. Dep is deprecated since 1.11.

And the last release tag of go-python/cpy3 is 0.1.1. In v0 version of the semantic versioning model, a developer with code consuming functions in a v0 module is responsible for adapting to incompatible changes until v1 is released. (ref: version-numbers)

I don' t think any module need to support dep when 1.18.

@christian-korneck
Copy link
Collaborator

christian-korneck commented Jun 13, 2022

I don' t think any module need to support dep

Agreed to break support for dep.

I was more worried about GO111MODULE=off situations. However, after reading through 1 and 2 I think it should be OK to use your change (add go.mod) and add a v0.2.0 tag. (Note: tags need to have a v prefix from now on to work with modules).

Let me verify a few things tonight and if there are no surprises I’ll merge this.

@christian-korneck christian-korneck merged commit 98d3175 into go-python:master Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go module
2 participants