Skip to content

Multi-context execution (py.Context) #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 81 commits into from
Closed
Show file tree
Hide file tree
Changes from 65 commits
Commits
Show all changes
81 commits
Select commit Hold shift + click to select a range
fc66b7f
py.CompileMode now a string enum
Dec 8, 2021
d10c35f
addressed benign Go warnings
Dec 8, 2021
2161b71
make Float implement M__index__
Dec 8, 2021
247ec42
added string helper functions
Dec 8, 2021
9a75271
updated to 1.15
Dec 8, 2021
90a8988
new Ctx-aware module model
Dec 9, 2021
c51644e
py.Ctx model allows concurrent execution
Dec 9, 2021
7f7d213
repl.New() now accepts an existing py.Ctx
Dec 9, 2021
708bb7e
fixed typo in callInternal()
Dec 9, 2021
a244256
unbroke test compatibilty
Dec 9, 2021
75d8743
cleaned up py.Ctx initialization wrt sys and DefaultCtxOpts()
Dec 10, 2021
d5fb8e8
added multi Ctx benchmark
Dec 10, 2021
269bdc0
WIP
Dec 10, 2021
4db9c65
fixed py.NewCtx not being set
Dec 10, 2021
53d05db
fixed List.sort() detection of instance invocation
Dec 10, 2021
7fd1c29
separated path resolution from path evaluation
Dec 11, 2021
8f3a104
removed cruft
Dec 18, 2021
5ebaf66
place ctx at top
Dec 18, 2021
d423190
err msg tweak
drew-512 Dec 18, 2021
b33c266
typo fix
drew-512 Dec 18, 2021
efca761
for loops we can all agree on
drew-512 Dec 18, 2021
1569475
removed outdated comments
Dec 18, 2021
a9c5f1f
Merge branch 'master' of https://github.com/drew-512/gpython
Dec 18, 2021
6372aee
added info for Frame.Ctx
Dec 19, 2021
4af4f90
removed unnecessary assignment
Dec 19, 2021
aec59f8
copyright and formatting
Dec 19, 2021
74f1a19
Ctx and NewCtx docs
Dec 19, 2021
8fa6622
switch cleanup
Dec 19, 2021
26fb9aa
leaner ModuleImpl schema
Dec 20, 2021
8614aeb
added GetDict() impl
Dec 20, 2021
86531c6
Compile() now returns py.Code (vs py.Object)
Dec 20, 2021
f71b961
tighter py.Ctx invocation patterns
Dec 20, 2021
77a7954
WIP
Dec 20, 2021
6bba7da
reverted to 644
Dec 20, 2021
46d1052
chmod 644
Dec 20, 2021
66fad23
enhanced RunFile() to enclose RunInNewModule()
Dec 27, 2021
95afd7b
Update examples/multi-ctx/main.go
drew-512 Jan 10, 2022
319edb7
Update modules/runtime.go
drew-512 Jan 10, 2022
06a2eae
Update modules/runtime.go
drew-512 Jan 10, 2022
8d4d586
Update modules/runtime.go
drew-512 Jan 10, 2022
d475e67
Update vm/eval.go
drew-512 Jan 10, 2022
6afac99
Update py/run.go
drew-512 Jan 10, 2022
931c346
Update modules/runtime.go
drew-512 Jan 10, 2022
a7ce4bb
Update modules/runtime.go
drew-512 Jan 10, 2022
c1f8809
Update modules/runtime.go
drew-512 Jan 10, 2022
9f02cf1
Update modules/runtime.go
drew-512 Jan 10, 2022
85e3a4a
Update modules/runtime.go
drew-512 Jan 10, 2022
fbec34e
Update modules/runtime.go
drew-512 Jan 10, 2022
dbd54d8
code cleanuo
Jan 10, 2022
71a5604
Module doc str
Jan 10, 2022
634823c
consistent arg order of NewFunction
Jan 10, 2022
6a0c11e
license and formatting
Jan 10, 2022
6242836
comment and cruft cleanup
Jan 10, 2022
61c7830
renamed Store to ModuleStore + docs
Jan 10, 2022
bb98aa8
added import docs
Jan 10, 2022
36b1018
shadowing cleanup
Jan 10, 2022
f2602bc
docs tweaks
Jan 10, 2022
e25e3bb
code cleanup
Jan 10, 2022
9421b6b
synced with gpython
Jan 10, 2022
92aed8a
Merge branch 'go-python:master' into master
drew-512 Jan 10, 2022
96515ea
Update modules/runtime.go
drew-512 Jan 10, 2022
f62f2b7
Update modules/runtime.go
drew-512 Jan 10, 2022
3bdba62
reverted from %w to %v (linux CI compile failure)
Jan 10, 2022
8033615
renamed py.Ctx to py.Context
Jan 10, 2022
681abf2
added Context.Close() and ModuleImpl.OnContextClosed()
Jan 18, 2022
7508556
docs and LoadIntsFromList
Jan 19, 2022
99bcb40
rename edits
Jan 21, 2022
0cc7650
push/popBusy now private
Jan 21, 2022
9afb2d3
doc edits
Jan 21, 2022
7d2a8d9
fixed kwarg issues in ParseTupleAndKeywords() and builtin_print test
Jan 25, 2022
ba7db80
added Flush kwarg to print test
Jan 25, 2022
61e42c8
added embedding example
Jan 26, 2022
168c337
main README makeover
Jan 26, 2022
2b7e1ab
fixed type conversion
Jan 26, 2022
3821b4b
Update README.md
drew-512 Jan 28, 2022
170f0d2
Update README.md
drew-512 Jan 28, 2022
b68b9f6
Update py/util.go
drew-512 Jan 28, 2022
759023b
Update py/util.go
drew-512 Jan 28, 2022
0c77716
Update py/util.go
drew-512 Jan 28, 2022
505755d
LoadIntsFromList cleanup
Jan 28, 2022
02d6b3e
comment edits
Jan 28, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file modified ast/asdl_go.py
100755 → 100644
Empty file.
Empty file modified ast/asttest.py
100755 → 100644
Empty file.
37 changes: 25 additions & 12 deletions builtin/builtin.go
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,17 @@ func init() {
"Warning": py.Warning,
"ZeroDivisionError": py.ZeroDivisionError,
}
py.NewModule("builtins", builtin_doc, methods, globals)

py.RegisterModule(&py.ModuleImpl{
Info: py.ModuleInfo{
Name: "builtins",
Doc: builtin_doc,
Flags: py.ShareModule,
},
Methods: methods,
Globals: globals,
})

}

const print_doc = `print(value, ..., sep=' ', end='\\n', file=sys.stdout, flush=False)
Expand All @@ -178,18 +188,22 @@ func builtin_print(self py.Object, args py.Tuple, kwargs py.StringDict) (py.Obje
var (
sepObj py.Object = py.String(" ")
endObj py.Object = py.String("\n")
file py.Object = py.MustGetModule("sys").Globals["stdout"]
flush py.Object
)
sysModule, err := self.(*py.Module).Context.GetModule("sys")
if err != nil {
return nil, err
}
stdout := sysModule.Globals["stdout"]
kwlist := []string{"sep", "end", "file", "flush"}
err := py.ParseTupleAndKeywords(nil, kwargs, "|ssOO:print", kwlist, &sepObj, &endObj, &file, &flush)
err = py.ParseTupleAndKeywords(nil, kwargs, "|ssOO:print", kwlist, &sepObj, &endObj, &stdout, &flush)
if err != nil {
return nil, err
}
sep := sepObj.(py.String)
end := endObj.(py.String)

write, err := py.GetAttrString(file, "write")
write, err := py.GetAttrString(stdout, "write")
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -219,7 +233,7 @@ func builtin_print(self py.Object, args py.Tuple, kwargs py.StringDict) (py.Obje
}

if shouldFlush, _ := py.MakeBool(flush); shouldFlush == py.True {
fflush, err := py.GetAttrString(file, "flush")
fflush, err := py.GetAttrString(stdout, "flush")
if err == nil {
return py.Call(fflush, nil, nil)
}
Expand Down Expand Up @@ -449,7 +463,7 @@ func builtin___build_class__(self py.Object, args py.Tuple, kwargs py.StringDict
}
// fmt.Printf("Calling %v with %v and %v\n", fn.Name, fn.Globals, ns)
// fmt.Printf("Code = %#v\n", fn.Code)
cell, err = py.VmRun(fn.Globals, ns, fn.Code, fn.Closure)
cell, err = fn.Context.RunCode(fn.Code, fn.Globals, ns, fn.Closure)
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -749,9 +763,9 @@ func builtin_compile(self py.Object, args py.Tuple, kwargs py.StringDict) (py.Ob
return nil, py.ExceptionNewf(py.ValueError, "compile(): invalid optimize value")
}

if dont_inherit.(py.Int) != 0 {
// PyEval_MergeCompilerFlags(&cf)
}
// if dont_inherit.(py.Int) != 0 {
// PyEval_MergeCompilerFlags(&cf)
// }

// switch string(startstr.(py.String)) {
// case "exec":
Expand Down Expand Up @@ -782,7 +796,7 @@ func builtin_compile(self py.Object, args py.Tuple, kwargs py.StringDict) (py.Ob
return nil, err
}
// result = py.CompileStringExFlags(str, filename, start[mode], &cf, optimize)
result, err = compile.Compile(str, string(filename.(py.String)), string(startstr.(py.String)), int(supplied_flags.(py.Int)), dont_inherit.(py.Int) != 0)
result, err = compile.Compile(str, string(filename.(py.String)), py.CompileMode(startstr.(py.String)), int(supplied_flags.(py.Int)), dont_inherit.(py.Int) != 0)
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -882,9 +896,8 @@ or ... etc.
`

func isinstance(obj py.Object, classOrTuple py.Object) (py.Bool, error) {
switch classOrTuple.(type) {
switch class_tuple := classOrTuple.(type) {
case py.Tuple:
var class_tuple = classOrTuple.(py.Tuple)
for idx := range class_tuple {
res, _ := isinstance(obj, class_tuple[idx])
if res {
Expand Down
24 changes: 13 additions & 11 deletions compile/compile.go
Original file line number Diff line number Diff line change
Expand Up @@ -89,33 +89,36 @@ func init() {
py.Compile = Compile
}

// Compile(source, filename, mode, flags, dont_inherit) -> code object
// Compile(src, srcDesc, compileMode, flags, dont_inherit) -> code object
//
// Compile the source string (a Python module, statement or expression)
// into a code object that can be executed by exec() or eval().
// The filename will be used for run-time error messages.
// The mode must be 'exec' to compile a module, 'single' to compile a
// single (interactive) statement, or 'eval' to compile an expression.
// into a code object that can be executed.
//
// srcDesc is used for run-time error messages and is typically a file system pathname,
//
// See py.CompileMode for compile mode options.
//
// The flags argument, if present, controls which future statements influence
// the compilation of the code.
//
// The dont_inherit argument, if non-zero, stops the compilation inheriting
// the effects of any future statements in effect in the code calling
// compile; if absent or zero these statements do influence the compilation,
// in addition to any features explicitly specified.
func Compile(str, filename, mode string, futureFlags int, dont_inherit bool) (py.Object, error) {
func Compile(src, srcDesc string, mode py.CompileMode, futureFlags int, dont_inherit bool) (*py.Code, error) {
// Parse Ast
Ast, err := parser.ParseString(str, mode)
Ast, err := parser.ParseString(src, mode)
if err != nil {
return nil, err
}
// Make symbol table
SymTable, err := symtable.NewSymTable(Ast, filename)
SymTable, err := symtable.NewSymTable(Ast, srcDesc)
if err != nil {
return nil, err
}
c := newCompiler(nil, compilerScopeModule)
c.Filename = filename
err = c.compileAst(Ast, filename, futureFlags, dont_inherit, SymTable)
c.Filename = srcDesc
err = c.compileAst(Ast, srcDesc, futureFlags, dont_inherit, SymTable)
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -1342,7 +1345,6 @@ func (c *compiler) NameOp(name string, ctx ast.ExprContext) {
default:
panic("NameOp: ctx invalid for name variable")
}
break
}
if op == 0 {
panic("NameOp: Op not set")
Expand Down
2 changes: 1 addition & 1 deletion compile/compile_data_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import (

var compileTestData = []struct {
in string
mode string // exec, eval or single
mode py.CompileMode
out *py.Code
exceptionType *py.Type
errString string
Expand Down
15 changes: 5 additions & 10 deletions compile/compile_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ func EqCode(t *testing.T, name string, a, b *py.Code) {
func TestCompile(t *testing.T) {
for _, test := range compileTestData {
// log.Printf(">>> %s", test.in)
codeObj, err := Compile(test.in, "<string>", test.mode, 0, true)
code, err := Compile(test.in, "<string>", test.mode, 0, true)
if err != nil {
if test.exceptionType == nil {
t.Errorf("%s: Got exception %v when not expecting one", test.in, err)
Expand Down Expand Up @@ -196,17 +196,12 @@ func TestCompile(t *testing.T) {
}
} else {
if test.out == nil {
if codeObj != nil {
t.Errorf("%s: Expecting nil *py.Code but got %T", test.in, codeObj)
if code != nil {
t.Errorf("%s: Expecting nil *py.Code but got %T", test.in, code)
}
} else {
code, ok := codeObj.(*py.Code)
if !ok {
t.Errorf("%s: Expecting *py.Code but got %T", test.in, codeObj)
} else {
//t.Logf("Testing %q", test.in)
EqCode(t, test.in, test.out, code)
}
//t.Logf("Testing %q", test.in)
EqCode(t, test.in, test.out, code)
}
}
}
Expand Down
Empty file modified compile/diffdis.py
100755 → 100644
Empty file.
Empty file modified compile/make_compile_test.py
100755 → 100644
Empty file.
138 changes: 138 additions & 0 deletions examples/multi-ctx/main.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,138 @@
// Copyright 2022 The go-python Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

package main

import (
"fmt"
"log"
"runtime"
"strings"
"sync"
"time"

// This initializes gpython for runtime execution and is critical.
// It defines forward-declared symbols and registers native built-in modules, such as sys and time.
_ "github.com/go-python/gpython/modules"

// This is the primary import for gpython.
// It contains all symbols needed to fully compile and run python.
"github.com/go-python/gpython/py"
)

func main() {

// The total job count implies a fixed amount of work.
// The number of workers is how many py.Context (in concurrent goroutines) to pull jobs off the queue.
// One worker does all the work serially while N number of workers will (ideally) divides up.
totalJobs := 20

for i := 0; i < 10; i++ {
numWorkers := i + 1
elapsed := RunMultiPi(numWorkers, totalJobs)
fmt.Printf("=====> %2d worker(s): %v\n\n", numWorkers, elapsed)

// Give each trial a fresh start
runtime.GC()
}

}

var jobScript = `
pi = chud.pi_chudnovsky_bs(numDigits)
last_5 = pi % 100000
print("%s: last 5 digits of %d is %d (job #%0d)" % (WORKER_ID, numDigits, last_5, jobID))
`

var jobSrcTemplate = `
import pi_chudnovsky_bs as chud

WORKER_ID = "{{WORKER_ID}}"

print("%s ready!" % (WORKER_ID))
`

type worker struct {
name string
ctx py.Context
main *py.Module
job *py.Code
}

func (w *worker) compileTemplate(pySrc string) {
pySrc = strings.Replace(pySrc, "{{WORKER_ID}}", w.name, -1)

mainImpl := py.ModuleImpl{
CodeSrc: pySrc,
}

var err error
w.main, err = w.ctx.ModuleInit(&mainImpl)
if err != nil {
log.Fatal(err)
}
}

func RunMultiPi(numWorkers, numTimes int) time.Duration {
var workersRunning sync.WaitGroup

fmt.Printf("Starting %d worker(s) to calculate %d jobs...\n", numWorkers, numTimes)

jobPipe := make(chan int)
go func() {
for i := 0; i < numTimes; i++ {
jobPipe <- i + 1
}
close(jobPipe)
}()

// Note that py.Code can be shared (accessed concurrently) since it is an inherently read-only object
jobCode, err := py.Compile(jobScript, "<jobScript>", py.ExecMode, 0, true)
if err != nil {
log.Fatal("jobScript failed to comple")
}

workers := make([]worker, numWorkers)
for i := 0; i < numWorkers; i++ {

opts := py.DefaultContextOpts()

// Make sure our import statement will find pi_chudnovsky_bs
opts.SysPaths = append(opts.SysPaths, "..")

workers[i] = worker{
name: fmt.Sprintf("Worker #%d", i+1),
ctx: py.NewContext(opts),
job: jobCode,
}

workersRunning.Add(1)
}

startTime := time.Now()

for i := range workers {
w := workers[i]
go func() {

// Compiling can be concurrent since there is no associated py.Context
w.compileTemplate(jobSrcTemplate)

for jobID := range jobPipe {
numDigits := 100000
if jobID%2 == 0 {
numDigits *= 10
}
py.SetAttrString(w.main.Globals, "numDigits", py.Int(numDigits))
py.SetAttrString(w.main.Globals, "jobID", py.Int(jobID))
w.ctx.RunCode(jobCode, w.main.Globals, w.main.Globals, nil)
}
workersRunning.Done()
}()
}

workersRunning.Wait()

return time.Since(startTime)
}
Empty file modified examples/pystone.py
100755 → 100644
Empty file.
13 changes: 8 additions & 5 deletions importlib/importlib.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,18 @@
package py

import (
"log"

"github.com/go-python/gpython/marshal"
"github.com/go-python/gpython/py"
)

// Load the frozen module
func init() {
_, err := marshal.LoadFrozenModule("importlib", data)
log.Fatalf("Failed to load importlib: %v", err)

py.RegisterModule(&py.ModuleImpl{
Info: py.ModuleInfo{
Name: "importlib",
},
CodeBuf: data,
})
}

// Auto-generated by Modules/_freeze_importlib.c
Expand Down
Loading