Skip to content

builtin: Update builtin_all and builtin_any for Python3 #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2018
Merged

builtin: Update builtin_all and builtin_any for Python3 #15

merged 1 commit into from
Aug 31, 2018

Conversation

corona10
Copy link
Collaborator

@corona10 corona10 commented Aug 30, 2018 •
edited
Loading

@corona10 corona10 requested review from ncw and sbinet August 30, 2018 05:51
@corona10 corona10 force-pushed the gh-14 branch 2 times, most recently from bfeae97 to c3410f1 Compare August 30, 2018 06:34
@corona10
Copy link
Collaborator Author

@sbinet

I've also fixed appveyor.yml for solving gcc issue which was happened on #13
PTAL

@codecov-io
Copy link

codecov-io commented Aug 30, 2018 •
edited
Loading

Codecov Report

Merging #15 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
- Coverage   64.43%   64.41%   -0.03%     
==========================================
  Files          55       55              
  Lines        9772     9766       -6     
==========================================
- Hits         6297     6291       -6     
  Misses       3008     3008              
  Partials      467      467
Impacted Files Coverage Δ
builtin/builtin.go 74.62% <100%> (-0.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60ae876...439862a. Read the comment docs.

@corona10 corona10 mentioned this pull request Aug 30, 2018
Merged
@sbinet
Copy link
Member

sbinet commented Aug 30, 2018

perhaps create a PR with only the appveyor stuff?
(so it can be merged very quickly)

@corona10
Copy link
Collaborator Author

@sbinet
Okay I will create a new PR by today

sbinet
sbinet previously approved these changes Aug 30, 2018
View reviewed changes
Copy link
Member

@sbinet sbinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbinet
Copy link
Member

sbinet commented Aug 30, 2018

it seems travis is in one of its bad days (it doesn't manage to find your commit...)

could you rebase on top of the latest master?
also, there's a typo in the CL:
s/refernce/reference/

@sbinet sbinet dismissed their stale review August 30, 2018 13:05

travis fails

@corona10
Copy link
Collaborator Author

@sbinet PTAL

sbinet
sbinet approved these changes Aug 30, 2018
View reviewed changes
Copy link
Member

@sbinet sbinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

let's wait for @ncw as well.

@corona10
Copy link
Collaborator Author

@ncw PTAL

@ncw
Copy link
Collaborator

ncw commented Aug 31, 2018

I think that looks great now :-)

@sbinet sbinet merged commit b55db0b into go-python:master Aug 31, 2018
@corona10 corona10 deleted the gh-14 branch August 31, 2018 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbinet sbinet sbinet approved these changes

@ncw ncw Awaiting requested review from ncw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@corona10 @codecov-io @sbinet @ncw