Skip to content

Improve some things around how errors are reported when parsing a file #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2022
Merged

Improve some things around how errors are reported when parsing a file #177

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fcddd1c
all: improve error logging when parsing a file
Apr 10, 2022
02c67b2
repl: make replTest.assert a T.Helper
sbinet May 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
repl: make replTest.assert a T.Helper 
Signed-off-by: Sebastien Binet <binet@cern.ch>
  • Loading branch information
@sbinet
sbinet committed May 5, 2022
commit 02c67b29f3d606329a3037182393d846cd90039e
1 change: 1 addition & 0 deletions repl/repl_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ func (rt *replTest) Print(out string) {
}

func (rt *replTest) assert(t *testing.T, what, wantPrompt, wantOut string) {
t.Helper()
if rt.prompt != wantPrompt {
t.Errorf("%s: Prompt wrong:\ngot= %q\nwant=%q", what, rt.prompt, wantPrompt)
}
Expand Down