Skip to content

py: Fix automatic addition of __doc__ to dict object (#229) #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 26, 2023

Conversation

natanfeitosa
Copy link
Contributor

@natanfeitosa natanfeitosa commented Dec 26, 2023

fixes #229

Copy link
Member

@sbinet sbinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR.

could you address the comments below ?

thanks.

Copy link
Contributor Author

@natanfeitosa natanfeitosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed unnecessary code

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (95c8e39) 75.44% compared to head (14fcffa) 75.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #230      +/-   ##
==========================================
+ Coverage   75.44%   75.45%   +0.01%     
==========================================
  Files          79       79              
  Lines       13214    13214              
==========================================
+ Hits         9969     9971       +2     
+ Misses       2569     2568       -1     
+ Partials      676      675       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbinet
Copy link
Member

sbinet commented Dec 26, 2023

thanks a lot.

could you send another PR against https://github.com/go-python/license adding yourself to the AUTHORS and/or CONTRIBUTORS file(s) ?
(then I'll merge this one in)

@sbinet
Copy link
Member

sbinet commented Dec 26, 2023

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when i try to get the __doc__ from a type like str
2 participants