Skip to content

builtin: Implement enumerate feature #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 26, 2018
Merged

Conversation

corona10
Copy link
Collaborator

Now, gpython supports enumerate feature

@codecov-io
Copy link

codecov-io commented Dec 25, 2018

Codecov Report

Merging #43 into master will increase coverage by 0.3%.
The diff coverage is 72.22%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #43     +/-   ##
=========================================
+ Coverage   65.24%   65.55%   +0.3%     
=========================================
  Files          56       57      +1     
  Lines       10150    10186     +36     
=========================================
+ Hits         6622     6677     +55     
+ Misses       3066     3040     -26     
- Partials      462      469      +7
Impacted Files Coverage Δ
builtin/builtin.go 78.72% <100%> (+0.05%) ⬆️
py/enumerate.go 71.42% <71.42%> (ø)
py/arithmetic.go 61.69% <0%> (+1.11%) ⬆️
py/function.go 25.95% <0%> (+1.52%) ⬆️
py/tuple.go 24.52% <0%> (+2.83%) ⬆️
py/list.go 11.83% <0%> (+2.95%) ⬆️
py/sequence.go 23.65% <0%> (+3.22%) ⬆️
py/iterator.go 73.33% <0%> (+73.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7ea0a4...afd9be0. Read the comment docs.

@corona10 corona10 force-pushed the enumerate branch 2 times, most recently from cfd27cb to 0f75714 Compare December 25, 2018 11:37
@corona10
Copy link
Collaborator Author

@ncw PTAL

Now, gpython supports enumerate feature
Copy link
Collaborator

@ncw ncw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great :-)

I didn't know enumerate took another parameter!

@ncw ncw merged commit 5e97b9b into go-python:master Dec 26, 2018
@corona10
Copy link
Collaborator Author

@ncw
It's the funniest part of this work!

@corona10 corona10 deleted the enumerate branch December 27, 2018 00:52
@ncw
Copy link
Collaborator

ncw commented Dec 29, 2018

@ncw
It's the funniest part of this work!

Indeed, learning lots of arcane things about python!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants