web_editor: prohibit CRUD to symbolic files #7981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a check to block CRUD operations on symbolic links in the web editor, addressing the GHSA advisory.
- Introduces
IsSymlinkinosutiland corresponding tests. - Adds security guards in
repo_editor.goto prevent creating, updating, moving, deleting, or uploading through symlinks. - Renames test fields from
expValtowantand updates imports.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/osutil/osutil.go | Added IsSymlink function to detect symbolic links. |
| internal/osutil/osutil_test.go | Added TestIsSymlink and renamed expVal to want in existing tests. |
| internal/database/repo_editor.go | Inserted symlink checks before filesystem operations in editor methods. |
Comments suppressed due to low confidence (1)
internal/database/repo_editor.go:167
- Add tests for the repository editor methods to confirm that operations against symlinked paths are properly rejected, ensuring these new security branches are covered.
if com.IsExist(filePath) {
Resolved issues in internal/osutil/osutil_test.go with DeepSource Autofix
b767ca1 to
2503dde
Compare
unknwon
added a commit
that referenced
this pull request
Jun 8, 2025
Fixes [GHSA-wj44-9vcg-wjq7](GHSA-wj44-9vcg-wjq7) --------- Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
|
The 0.13.3 has been released that includes this patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GHSA-wj44-9vcg-wjq7