Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/crypto
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0d375be
Choose a base ref
...
head repository: golang/crypto
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e3cc52e
Choose a head ref
  • 10 commits
  • 28 files changed
  • 6 contributors

Commits on Sep 5, 2023

  1. ssh: check the declared public key algo against decoded one

    This check will ensure we don't accept e.g. ssh-rsa-cert-v01@openssh.com
    algorithm with ssh-rsa public key type.
    The algorithm and public key type must be consistent: both must be
    certificate algorithms, or neither.
    
    Change-Id: I1d75074fb4d6db3a8796408e98ddffe577a96ab1
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/506836
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Reviewed-by: Cherry Mui <cherryyz@google.com>
    Auto-Submit: Filippo Valsorda <filippo@golang.org>
    Reviewed-by: Filippo Valsorda <filippo@golang.org>
    Run-TryBot: Filippo Valsorda <filippo@golang.org>
    drakkan authored and gopherbot committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    c5370d2 View commit details
    Browse the repository at this point in the history
  2. ssh: support for marshaling keys using the OpenSSH format

    This adds methods to marshal private keys, encrypted and unencrypted
    to the OpenSSH format.
    
    Fixes golang/go#37132
    
    Change-Id: I1a95301f789ce04858e6b147748c6e8b7700384b
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/218620
    Run-TryBot: Roland Shoemaker <roland@golang.org>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Cherry Mui <cherryyz@google.com>
    Reviewed-by: Roland Shoemaker <roland@golang.org>
    Auto-Submit: Roland Shoemaker <roland@golang.org>
    maraino authored and gopherbot committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    d359caa View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. cryptobyte: add uint48 methods

    Adds uint48 methods for cryptobyte.Builder and cryptobyte.String.
    Supporting 48-bit unsigned integers is useful for working with protocols
    that use them for sequence numbers, such as DTLS.
    
    Fixes golang/go#61275
    
    Change-Id: Ibe49422d37644b9212b28b123dc5e01850f7b05b
    GitHub-Last-Rev: 11b388c
    GitHub-Pull-Request: #265
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/508675
    Reviewed-by: Roland Shoemaker <roland@golang.org>
    Reviewed-by: Cherry Mui <cherryyz@google.com>
    Reviewed-by: qiulaidongfeng <2645477756@qq.com>
    Run-TryBot: Roland Shoemaker <roland@golang.org>
    Auto-Submit: Roland Shoemaker <roland@golang.org>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    hasheddan authored and gopherbot committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    e90f1e1 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2023

  1. sha3: have ShakeHash extend hash.Hash

    Package sha3 recommends the SHAKE functions for new uses, but this is
    currently somewhat inconvenient because ShakeHash does not implement
    hash.Hash. This is understandable, as SHAKE supports arbitrary-length
    outputs whereas hash.Hash only supports fixed-length outputs. But
    there's a natural fixed-length output to provide: the minimum output
    that still provides SHAKE's full-strength generic security.
    
    While here, tweak Sum so that its temporary buffer can be stack
    allocated.
    
    Also, tweak the panic message in Write so that the error text is more
    readily understandable to Go programmers without needing to be
    familiar with crypto jargon, and add a similar check in Sum.
    
    Change-Id: Icf037d3990a71de5630f8825606614443f8c5245
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/526937
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Adam Langley <agl@google.com>
    Auto-Submit: Matthew Dempsky <mdempsky@google.com>
    mdempsky authored and gopherbot committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    3f0842a View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. ssh: add MultiAlgorithmSigner

    MultiAlgorithmSigner allows to restrict client-side, server-side and
    certificate signing algorithms.
    
    Fixes golang/go#52132
    Fixes golang/go#36261
    
    Change-Id: I295092f1bba647327aaaf294f110e9157d294159
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/508398
    Reviewed-by: Filippo Valsorda <filippo@golang.org>
    Run-TryBot: Filippo Valsorda <filippo@golang.org>
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    Auto-Submit: Filippo Valsorda <filippo@golang.org>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Reviewed-by: Matthew Dempsky <mdempsky@google.com>
    drakkan authored and gopherbot committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    28c53ff View commit details
    Browse the repository at this point in the history
  2. ssh: add test cases for compatibility with old (buggy) clients

    Improved test cases for CL 506835.
    
    Change-Id: If4a98ae4a7b39d2e59b203d10080b71283e1a80e
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/525735
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Reviewed-by: Matthew Dempsky <mdempsky@google.com>
    Run-TryBot: Filippo Valsorda <filippo@golang.org>
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    Reviewed-by: Filippo Valsorda <filippo@golang.org>
    Auto-Submit: Filippo Valsorda <filippo@golang.org>
    drakkan authored and gopherbot committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    a1aeb9b View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. all: use crypto/ed25519 instead of golang.org/x/crypto/ed25519

    This is a follow-up to CL 317169, which dropped go1.12 compatibility,
    and made the golang.org/x/crypto/ed25519 package an alias / wrapper for
    crypto/ed25519 in stdlib.
    
    This patch updates uses within this repository to use stdlib instead of
    depending on the wrapper. With this patch applied, the only remaining
    use of the wrapper is in ed25519_test, which appears to be in place to
    verify compatibility of the wrapper itself.
    
    Change-Id: I0195396102a75ae20bdd82ca8ab59855c0eb5cea
    GitHub-Last-Rev: 24dbec5
    GitHub-Pull-Request: #238
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/448238
    Reviewed-by: Bryan Mills <bcmills@google.com>
    Run-TryBot: Nicola Murino <nicola.murino@gmail.com>
    Reviewed-by: Nicola Murino <nicola.murino@gmail.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Reviewed-by: Joedian Reid <joedian@golang.org>
    Reviewed-by: Roland Shoemaker <roland@golang.org>
    Reviewed-by: Than McIntosh <thanm@google.com>
    thaJeztah authored and FiloSottile committed Sep 27, 2023
    1 Configuration menu
    Copy the full SHA
    b665ba6 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. chacha20: drop Go 1.10 compatibility for arm64

    Other packages already dropped compatibility with go < 1.12, so it should be safe to remove it for this package as well.
    
    Change-Id: Ib1424763e3aa94d0187a667ebee058100136f53b
    GitHub-Last-Rev: 51df969
    GitHub-Pull-Request: #241
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/448241
    Reviewed-by: Roland Shoemaker <roland@golang.org>
    Auto-Submit: Filippo Valsorda <filippo@golang.org>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Reviewed-by: Than McIntosh <thanm@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Run-TryBot: Roland Shoemaker <roland@golang.org>
    Reviewed-by: Filippo Valsorda <filippo@golang.org>
    Reviewed-by: Joedian Reid <joedian@golang.org>
    thaJeztah authored and gopherbot committed Sep 28, 2023
    1 Configuration menu
    Copy the full SHA
    ec07f4e View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. ssh: add server side support for ping@openssh.com protocol extension

    Fixes golang/go#62390
    
    Change-Id: Ie4dc577fb55b45a0c26a9e2dc5903af2bd382e00
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/524775
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Reviewed-by: Matthew Dempsky <mdempsky@google.com>
    Reviewed-by: Than McIntosh <thanm@google.com>
    Run-TryBot: Nicola Murino <nicola.murino@gmail.com>
    Reviewed-by: Filippo Valsorda <filippo@golang.org>
    drakkan authored and FiloSottile committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    833695f View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. go.mod: update golang.org/x dependencies

    Update golang.org/x dependencies to their latest tagged versions.
    
    Change-Id: Ib80d50bdd762d1ba04f9267aeddc17272ef8cd66
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/532976
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Carlos Amedee <carlos@golang.org>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Auto-Submit: Gopher Robot <gobot@golang.org>
    gopherbot committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    e3cc52e View commit details
    Browse the repository at this point in the history
Loading