Skip to content

x/tools/gopls/internal/telemetry/cmd/stacks: TestReadPCLineTable/gopls failures #71805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
gopherbot opened this issue Feb 17, 2025 · 6 comments
Open

x/tools/gopls/internal/telemetry/cmd/stacks: TestReadPCLineTable/gopls failures #71805

gopherbot opened this issue Feb 17, 2025 · 6 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/backlog

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/telemetry/cmd/stacks" && test == "TestReadPCLineTable/gopls"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestReadPCLineTable/gopls
2025/01/27 09:06:48 cloning tools@gopls/v0.16.1
    stacks_test.go:66: readPCLineTable got err clone: checking out https://go.googlesource.com/tools: signal: killed
        hint: Using 'master' as the name for the initial branch. This default branch name
        hint: is subject to change. To configure the initial branch name to use in all
        hint: of your new repositories, which will suppress this warning, call:
        hint: 
        hint: 	git config --global init.defaultBranch <name>
        hint: 
        hint: Names commonly chosen instead of 'master' are 'main', 'trunk' and
        hint: 'development'. The just-created branch can be renamed via this command:
        hint: 
        hint: 	git branch -m <name>
        Initialized empty Git repository in /Users/swarming/.swarming/w/ir/x/t/TestReadPCLineTablegopls30401385/001/v0.16.1/.git/
        From https://go.googlesource.com/tools
         * tag               gopls/v0.16.1 -> FETCH_HEAD
         want nil
--- FAIL: TestReadPCLineTable/gopls (277.66s)

— watchflakes
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/telemetry/cmd/stacks" && test == "TestReadPCLineTable/gopls"
2025-01-27 15:32 x_tools-go1.24-darwin-amd64-longtest tools@bb0a9cda release-branch.go1.24@8a4c24f9 x/tools/gopls/internal/telemetry/cmd/stacks.TestReadPCLineTable/gopls (log) 
=== RUN   TestReadPCLineTable/gopls
2025/01/27 09:06:48 cloning tools@gopls/v0.16.1
    stacks_test.go:66: readPCLineTable got err clone: checking out https://go.googlesource.com/tools: signal: killed
        hint: Using 'master' as the name for the initial branch. This default branch name
        hint: is subject to change. To configure the initial branch name to use in all
        hint: of your new repositories, which will suppress this warning, call:
        hint: 
        hint: 	git config --global init.defaultBranch <name>
        hint: 
        hint: Names commonly chosen instead of 'master' are 'main', 'trunk' and
        hint: 'development'. The just-created branch can be renamed via this command:
        hint: 
        hint: 	git branch -m <name>
        Initialized empty Git repository in /Users/swarming/.swarming/w/ir/x/t/TestReadPCLineTablegopls30401385/001/v0.16.1/.git/
        From https://go.googlesource.com/tools
         * tag               gopls/v0.16.1 -> FETCH_HEAD
         want nil
--- FAIL: TestReadPCLineTable/gopls (277.66s)
2025-02-06 14:18 x_tools-gotip-darwin-amd64-longtest tools@6557d184 go@a8e532b0 x/tools/gopls/internal/telemetry/cmd/stacks.TestReadPCLineTable/gopls (log) 
=== RUN   TestReadPCLineTable/gopls
2025/02/06 06:52:20 cloning tools@gopls/v0.16.1
    stacks_test.go:66: readPCLineTable got err clone: checking out https://go.googlesource.com/tools: signal: killed
        hint: Using 'master' as the name for the initial branch. This default branch name
        hint: is subject to change. To configure the initial branch name to use in all
        hint: of your new repositories, which will suppress this warning, call:
        hint: 
        hint: 	git config --global init.defaultBranch <name>
        hint: 
        hint: Names commonly chosen instead of 'master' are 'main', 'trunk' and
        hint: 'development'. The just-created branch can be renamed via this command:
        hint: 
        hint: 	git branch -m <name>
        Initialized empty Git repository in /Users/swarming/.swarming/w/ir/x/t/TestReadPCLineTablegopls2260682417/001/v0.16.1/.git/
        From https://go.googlesource.com/tools
         * tag               gopls/v0.16.1 -> FETCH_HEAD
         want nil
--- FAIL: TestReadPCLineTable/gopls (79.56s)
2025-02-14 17:02 x_tools-gotip-darwin-amd64-longtest tools@32ffaa31 go@d524e1ec x/tools/gopls/internal/telemetry/cmd/stacks.TestReadPCLineTable/gopls (log) 
=== RUN   TestReadPCLineTable/gopls
2025/02/16 08:02:50 cloning tools@gopls/v0.16.1
    stacks_test.go:66: readPCLineTable got err clone: checking out https://go.googlesource.com/tools: signal: killed
        hint: Using 'master' as the name for the initial branch. This default branch name
        hint: is subject to change. To configure the initial branch name to use in all
        hint: of your new repositories, which will suppress this warning, call:
        hint: 
        hint: 	git config --global init.defaultBranch <name>
        hint: 
        hint: Names commonly chosen instead of 'master' are 'main', 'trunk' and
        hint: 'development'. The just-created branch can be renamed via this command:
        hint: 
        hint: 	git branch -m <name>
        Initialized empty Git repository in /Users/swarming/.swarming/w/ir/x/t/TestReadPCLineTablegopls3632661269/001/v0.16.1/.git/
        From https://go.googlesource.com/tools
         * tag               gopls/v0.16.1 -> FETCH_HEAD
         want nil
--- FAIL: TestReadPCLineTable/gopls (285.44s)

— watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 17, 2025
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Feb 17, 2025
@gopherbot gopherbot added this to the Unreleased milestone Feb 17, 2025
@adonovan adonovan moved this to Active in Test Flakes Feb 18, 2025
@findleyr findleyr modified the milestones: Unreleased, gopls/v0.19.0 Feb 21, 2025
@findleyr
Copy link
Member

This looks like a real (albeit inconsequential) flake. Moving to the v0.19.0 milestone.

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/telemetry/cmd/stacks" && test == "TestReadPCLineTable/gopls"
2025-02-27 18:07 x_tools-go1.24-darwin-amd64-longtest tools@8f4b8cd6 release-branch.go1.24@5d692084 x/tools/gopls/internal/telemetry/cmd/stacks.TestReadPCLineTable/gopls (log) 
=== RUN   TestReadPCLineTable/gopls
2025/02/27 11:19:53 cloning tools@gopls/v0.16.1
    stacks_test.go:66: readPCLineTable got err clone: checking out https://go.googlesource.com/tools: signal: killed
        hint: Using 'master' as the name for the initial branch. This default branch name
        hint: is subject to change. To configure the initial branch name to use in all
        hint: of your new repositories, which will suppress this warning, call:
        hint: 
        hint: 	git config --global init.defaultBranch <name>
        hint: 
        hint: Names commonly chosen instead of 'master' are 'main', 'trunk' and
        hint: 'development'. The just-created branch can be renamed via this command:
        hint: 
        hint: 	git branch -m <name>
        Initialized empty Git repository in /Users/swarming/.swarming/w/ir/x/t/TestReadPCLineTablegopls478460483/001/v0.16.1/.git/
        From https://go.googlesource.com/tools
         * tag               gopls/v0.16.1 -> FETCH_HEAD
         want nil
--- FAIL: TestReadPCLineTable/gopls (177.72s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/telemetry/cmd/stacks" && test == "TestReadPCLineTable/gopls"
2025-03-12 20:44 x_tools-go1.24-darwin-amd64-longtest tools@40f8cca0 release-branch.go1.24@c2a34bed x/tools/gopls/internal/telemetry/cmd/stacks.TestReadPCLineTable/gopls (log) 
=== RUN   TestReadPCLineTable/gopls
2025/03/12 15:08:24 cloning tools@gopls/v0.16.1
    stacks_test.go:66: readPCLineTable got err clone: checking out https://go.googlesource.com/tools: signal: killed
        hint: Using 'master' as the name for the initial branch. This default branch name
        hint: is subject to change. To configure the initial branch name to use in all
        hint: of your new repositories, which will suppress this warning, call:
        hint: 
        hint: 	git config --global init.defaultBranch <name>
        hint: 
        hint: Names commonly chosen instead of 'master' are 'main', 'trunk' and
        hint: 'development'. The just-created branch can be renamed via this command:
        hint: 
        hint: 	git branch -m <name>
        Initialized empty Git repository in /Users/swarming/.swarming/w/ir/x/t/TestReadPCLineTablegopls3663650645/001/v0.16.1/.git/
        From https://go.googlesource.com/tools
         * tag               gopls/v0.16.1 -> FETCH_HEAD
         want nil
--- FAIL: TestReadPCLineTable/gopls (68.91s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/telemetry/cmd/stacks" && test == "TestReadPCLineTable/gopls"
2025-03-26 14:12 x_tools-gotip-darwin-amd64-longtest tools@b3ce3e13 go@9ce47e66 x/tools/gopls/internal/telemetry/cmd/stacks.TestReadPCLineTable/gopls (log) 
=== RUN   TestReadPCLineTable/gopls
2025/03/26 07:36:06 cloning tools@gopls/v0.16.1
    stacks_test.go:66: readPCLineTable got err clone: checking out https://go.googlesource.com/tools: signal: killed
        hint: Using 'master' as the name for the initial branch. This default branch name
        hint: is subject to change. To configure the initial branch name to use in all
        hint: of your new repositories, which will suppress this warning, call:
        hint: 
        hint: 	git config --global init.defaultBranch <name>
        hint: 
        hint: Names commonly chosen instead of 'master' are 'main', 'trunk' and
        hint: 'development'. The just-created branch can be renamed via this command:
        hint: 
        hint: 	git branch -m <name>
        Initialized empty Git repository in /Users/swarming/.swarming/w/ir/x/t/TestReadPCLineTablegopls1056361489/001/v0.16.1/.git/
        From https://go.googlesource.com/tools
         * tag               gopls/v0.16.1 -> FETCH_HEAD
         want nil
--- FAIL: TestReadPCLineTable/gopls (169.91s)

— watchflakes

@adonovan
Copy link
Member

I think this is a failure of builder infrastructure. It looks like a git clone is running so slow (starved of CPU? slow network?) that after almost 3 minutes it gets killed, leading to a bad checkout.

--- FAIL: TestReadPCLineTable (331.23s)
--- FAIL: TestReadPCLineTable/gopls (169.91s)
2025/03/26 07:36:06 cloning tools@gopls/v0.16.1
    stacks_test.go:66: readPCLineTable got err clone: checking out https://go.googlesource.com/tools: signal: killed
        hint: Using 'master' as the name for the initial branch. This default branch name ...etc...
        Initialized empty Git repository in /Users/swarming/.swarming/w/ir/x/t/TestReadPCLineTablegopls1056361489/001/v0.16.1/.git/
        From https://go.googlesource.com/tools
         * tag               gopls/v0.16.1 -> FETCH_HEAD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: Active
Milestone
gopls/backlog
Development

No branches or pull requests
3 participants
@adonovan @gopherbot @findleyr