x/tools/gopls: Parse: crash in fixInitStmt #72026

adonovan · 2025-02-28T16:05:22Z

#!stacks
"goPanicSliceAcap" && "fixInitStmt:+10"

Issue created by stacks.

This is not how to use safetoken:

	// Try to extract a statement from the BadExpr.
	start, end, err := safetoken.Offsets(tok, bad.Pos(), bad.End()-1)
	if err != nil {
		return false
	}
	stmtBytes := src[start : end+1]
	stmt, err := parseStmt(tok, bad.Pos(), stmtBytes)
	if err != nil {
		return false
	}

This stack LKUsng was reported by telemetry:

crash/crash
runtime.gopanic:+69
runtime.goPanicSliceAcap:+2
golang.org/x/tools/gopls/internal/cache/parsego.fixInitStmt:+10
golang.org/x/tools/gopls/internal/cache/parsego.fixAST.func1:+27
golang.org/x/tools/gopls/internal/cache/parsego.walkASTWithParent.func1:+17
go/ast.inspector.Visit:+1
go/ast.Walk:+1
go/ast.Walk:+224
go/ast.walkList[...]:=21
go/ast.Walk:+178
go/ast.Walk:+239
go/ast.walkList[...]:=21
go/ast.Walk:+178
go/ast.Walk:+299
go/ast.walkList[...]:=21
go/ast.Walk:+308
go/ast.Inspect:=372
golang.org/x/tools/gopls/internal/cache/parsego.walkASTWithParent:+2
golang.org/x/tools/gopls/internal/cache/parsego.fixAST:+2
golang.org/x/tools/gopls/internal/cache/parsego.Parse:+57

golang.org/x/tools/gopls@v0.18.0 go1.24.0 linux/amd64 vscode (2)

Dups: Dyo-dQ Cys7zA hq9Myg 7jyMQQ sM9gIg _GxDgw

The text was updated successfully, but these errors were encountered:

gopherbot · 2025-02-28T16:12:01Z

Change https://go.dev/cl/653596 mentions this issue: gopls/internal/cache/parsego: fix OOB crash in fixInitStmt

gabyhelp · 2025-02-28T16:50:00Z

Related Issues

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

gopherbot · 2025-03-03T22:19:56Z

Change https://go.dev/cl/654336 mentions this issue: gopls/internal/cache: reproduce and fix crash on if cond overflow

Through reverse engineering, I was able to reproduce the overflow of golang/go#72026, and verify the fix of CL 653596. Along the way, I incidentally reproduced golang/go#66766, which I think we can safely ignore now that we understand it. Updates golang/go#72026 Fixes golang/go#66766 Change-Id: I2131d771c13688c1ad47f6bc6285e524fb4c04a1 Reviewed-on: https://go-review.googlesource.com/c/tools/+/654336 Reviewed-by: Alan Donovan <adonovan@google.com> Auto-Submit: Robert Findley <rfindley@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>

adonovan · 2025-03-06T17:30:07Z

This stack Dyo-dQ was reported by telemetry:

crash/crash
runtime.gopanic:+69
runtime.goPanicSliceAcap:+2
golang.org/x/tools/gopls/internal/cache/parsego.fixInitStmt:+10
golang.org/x/tools/gopls/internal/cache/parsego.fixAST.func1:+27
golang.org/x/tools/gopls/internal/cache/parsego.walkASTWithParent.func1:+17
go/ast.inspector.Visit:+1
go/ast.Walk:+1
go/ast.Walk:+184
go/ast.walkList[...]:=21
go/ast.Walk:+178
go/ast.Walk:+239
go/ast.walkList[...]:=21
go/ast.Walk:+178
go/ast.Walk:+299
go/ast.walkList[...]:=21
go/ast.Walk:+308
go/ast.Inspect:=372
golang.org/x/tools/gopls/internal/cache/parsego.walkASTWithParent:+2
golang.org/x/tools/gopls/internal/cache/parsego.fixAST:+2
golang.org/x/tools/gopls/internal/cache/parsego.Parse:+57

golang.org/x/tools/gopls@v0.18.1 go1.24.0 darwin/arm64 vscode (4)

adonovan · 2025-03-10T16:48:09Z

This stack Cys7zA was reported by telemetry:

crash/crash
runtime.gopanic:+69
runtime.goPanicSliceAcap:+2
golang.org/x/tools/gopls/internal/cache/parsego.fixInitStmt:+10
golang.org/x/tools/gopls/internal/cache/parsego.fixAST.func1:+27
golang.org/x/tools/gopls/internal/cache/parsego.walkASTWithParent.func1:+17
go/ast.inspector.Visit:+1
go/ast.Walk:+1
go/ast.Walk:+224
go/ast.walkList[...]:=21
go/ast.Walk:+178
go/ast.Walk:+299
go/ast.walkList[...]:=21
go/ast.Walk:+308
go/ast.Inspect:=372
golang.org/x/tools/gopls/internal/cache/parsego.walkASTWithParent:+2
golang.org/x/tools/gopls/internal/cache/parsego.fixAST:+2
golang.org/x/tools/gopls/internal/cache/parsego.Parse:+57
golang.org/x/tools/gopls/internal/cache.(*parseCache).startParse.func1:+5
golang.org/x/tools/internal/memoize.(*Promise).run.func2.1:+7

golang.org/x/tools/gopls@v0.18.1 go1.23.6 linux/amd64 vscode (2)

adonovan · 2025-03-17T17:34:59Z

This stack hq9Myg was reported by telemetry:

crash/crash
runtime.gopanic:+69
runtime.goPanicSliceAcap:+2
golang.org/x/tools/gopls/internal/cache/parsego.fixInitStmt:+10
golang.org/x/tools/gopls/internal/cache/parsego.fixAST.func1:+27
golang.org/x/tools/gopls/internal/cache/parsego.walkASTWithParent.func1:+17
go/ast.inspector.Visit:+1
go/ast.Walk:+1
go/ast.Walk:+199
go/ast.walkList[...]:=21
go/ast.Walk:+178
go/ast.Walk:+299
go/ast.walkList[...]:=21
go/ast.Walk:+308
go/ast.Inspect:=372
golang.org/x/tools/gopls/internal/cache/parsego.walkASTWithParent:+2
golang.org/x/tools/gopls/internal/cache/parsego.fixAST:+2
golang.org/x/tools/gopls/internal/cache/parsego.Parse:+96
golang.org/x/tools/gopls/internal/cache.(*parseCache).startParse.func1:+5
golang.org/x/tools/internal/memoize.(*Promise).run.func2.1:+7

golang.org/x/tools/gopls@v0.18.1 go1.24.0 linux/amd64 other,vscode (5)

adonovan · 2025-03-25T14:03:31Z

This stack 7jyMQQ was reported by telemetry:

crash/crash
runtime.gopanic:+69
runtime.goPanicSliceAcap:+2
golang.org/x/tools/gopls/internal/cache/parsego.fixInitStmt:+10
golang.org/x/tools/gopls/internal/cache/parsego.fixAST.func1:+27
golang.org/x/tools/gopls/internal/cache/parsego.walkASTWithParent.func1:+17
go/ast.inspector.Visit:+1
go/ast.Walk:+1
go/ast.Walk:+184
go/ast.walkList[...]:=21
go/ast.Walk:+178
go/ast.Walk:+299
go/ast.walkList[...]:=21
go/ast.Walk:+308
go/ast.Inspect:=372
golang.org/x/tools/gopls/internal/cache/parsego.walkASTWithParent:+2
golang.org/x/tools/gopls/internal/cache/parsego.fixAST:+2
golang.org/x/tools/gopls/internal/cache/parsego.Parse:+57
golang.org/x/tools/gopls/internal/cache.(*parseCache).startParse.func1:+5
golang.org/x/tools/internal/memoize.(*Promise).run.func2.1:+7

golang.org/x/tools/gopls@v0.18.1 go1.23.7 linux/amd64 vscode (1)

adonovan · 2025-04-08T14:38:44Z

This stack sM9gIg was reported by telemetry:

crash/crash
runtime.gopanic:+69
runtime.goPanicSliceAcap:+2
golang.org/x/tools/gopls/internal/cache/parsego.fixInitStmt:+10
golang.org/x/tools/gopls/internal/cache/parsego.fixAST.func1:+27
golang.org/x/tools/gopls/internal/cache/parsego.walkASTWithParent.func1:+17
go/ast.inspector.Visit:+1
go/ast.Walk:+1
go/ast.Walk:+184
go/ast.walkList[...]:=21
go/ast.Walk:+178
go/ast.Walk:+185
go/ast.walkList[...]:=21
go/ast.Walk:+178
go/ast.Walk:+229
go/ast.walkList[...]:=21
go/ast.Walk:+178
go/ast.Walk:+299
go/ast.walkList[...]:=21
go/ast.Walk:+308
go/ast.Inspect:=372

golang.org/x/tools/gopls@v0.18.1 go1.23.7 darwin/amd64 neovim,other (2)

adonovan · 2025-04-12T19:00:45Z

This stack _GxDgw was reported by telemetry:

crash/crash
runtime.gopanic:+69
runtime.goPanicSliceAcap:+2
golang.org/x/tools/gopls/internal/cache/parsego.fixInitStmt:+10
golang.org/x/tools/gopls/internal/cache/parsego.fixAST.func1:+27
golang.org/x/tools/gopls/internal/cache/parsego.walkASTWithParent.func1:+17
go/ast.inspector.Visit:+1
go/ast.Walk:+1
go/ast.Walk:+199
go/ast.walkList[...]:=21
go/ast.Walk:+178
go/ast.Walk:+299
go/ast.walkList[...]:=21
go/ast.Walk:+308
go/ast.Inspect:=372
golang.org/x/tools/gopls/internal/cache/parsego.walkASTWithParent:+2
golang.org/x/tools/gopls/internal/cache/parsego.fixAST:+2
golang.org/x/tools/gopls/internal/cache/parsego.Parse:+57
golang.org/x/tools/gopls/internal/cache.(*parseCache).startParse.func1:+5
golang.org/x/tools/internal/memoize.(*Promise).run.func2.1:+7

golang.org/x/tools/gopls@v0.18.1 go1.23.6 linux/amd64 vscode (1)

gopherbot added this to the Unreleased milestone Feb 28, 2025

adonovan self-assigned this Feb 28, 2025

gabyhelp added the BugReport Issues describing a possible bug in the Go implementation. label Feb 28, 2025

gopherbot closed this as completed in golang/tools@455db21 Mar 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

x/tools/gopls: Parse: crash in fixInitStmt #72026

x/tools/gopls: Parse: crash in fixInitStmt #72026

adonovan commented Feb 28, 2025 •

edited

Loading

gopherbot commented Feb 28, 2025

gabyhelp commented Feb 28, 2025

gopherbot commented Mar 3, 2025

adonovan commented Mar 6, 2025

adonovan commented Mar 10, 2025

adonovan commented Mar 17, 2025

adonovan commented Mar 25, 2025

adonovan commented Apr 8, 2025

adonovan commented Apr 12, 2025

x/tools/gopls: Parse: crash in fixInitStmt #72026

x/tools/gopls: Parse: crash in fixInitStmt #72026

Comments

adonovan commented Feb 28, 2025 • edited Loading

gopherbot commented Feb 28, 2025

gabyhelp commented Feb 28, 2025

gopherbot commented Mar 3, 2025

adonovan commented Mar 6, 2025

adonovan commented Mar 10, 2025

adonovan commented Mar 17, 2025

adonovan commented Mar 25, 2025

adonovan commented Apr 8, 2025

adonovan commented Apr 12, 2025

adonovan commented Feb 28, 2025 •

edited

Loading