Skip to content

cmd/compile: program compiles to wasm but is invalid: go:wasmexport: integer too large [1.24 backport] #73281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Apr 9, 2025 · 2 comments
Closed

cmd/compile: program compiles to wasm but is invalid: go:wasmexport: integer too large [1.24 backport] #73281

gopherbot opened this issue Apr 9, 2025 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Milestone
Go1.24.3

Comments

@gopherbot
Copy link
Contributor

@cherrymui requested issue #73246 to be considered for backport to the next 1.24 minor release.

@gopherbot please backport this to Go 1.24 release. Wasmexport is a new feature in Go 1.24. This fixes a miscompilation in a case that was missed in 1.24. Thanks.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Apr 9, 2025
@gopherbot gopherbot mentioned this issue Apr 9, 2025
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Apr 9, 2025
@gopherbot gopherbot added this to the Go1.24.3 milestone Apr 9, 2025
@prattmic prattmic added the CherryPickApproved Used during the release process for point releases label Apr 16, 2025
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Apr 16, 2025
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/668615 mentions this issue: [release-branch.go1.24] cmd/internal/obj/wasm: use i64 for large return addr

gopherbot pushed a commit that referenced this issue Apr 29, 2025
@Zxilly @cagedmantis
[release-branch.go1.24] cmd/internal/obj/wasm: use i64 for large retu…
f66ab65 
…rn addr

Use i64 to avoid overflow when getting PC_F from the return addr.

For #73246.
Fixes #73281.

Change-Id: I5683dccf7eada4b8536edf53e2e83116a2f6d943
GitHub-Last-Rev: 267d9a1
GitHub-Pull-Request: #73277
Reviewed-on: https://go-review.googlesource.com/c/go/+/663995
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
(cherry picked from commit d60a684)
Reviewed-on: https://go-review.googlesource.com/c/go/+/668615
Reviewed-by: Carlos Amedee <carlos@golang.org>
@gopherbot
Copy link
Contributor Author

Closed by merging CL 668615 (commit f66ab65) to release-branch.go1.24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Projects
None yet
Milestone
Go1.24.3
Development

No branches or pull requests
2 participants
@prattmic @gopherbot