Skip to content

cmd/compile: infinite loop in the inliner [1.24 backport] #73440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Apr 18, 2025 · 2 comments
Closed

cmd/compile: infinite loop in the inliner [1.24 backport] #73440

gopherbot opened this issue Apr 18, 2025 · 2 comments
Assignees
@dr2chase
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Milestone
Go1.24.3

Comments

@gopherbot
Copy link
Contributor

@dr2chase requested issue #73425 to be considered for backport to the next 1.24 minor release.

@gopherbot, please open a backport issue for 1.24. This is a serious compiler bug and a regression in 1.24.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Apr 18, 2025
@gopherbot gopherbot mentioned this issue Apr 18, 2025
Open
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Apr 18, 2025
@gopherbot gopherbot added this to the Go1.24.3 milestone Apr 18, 2025
@dr2chase dr2chase self-assigned this Apr 18, 2025
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/666555 mentions this issue: [release-branch.go1.24] cmd/compile: remove no-longer-necessary recursive inlining checks

@JunyangShao JunyangShao added the CherryPickApproved Used during the release process for point releases label Apr 23, 2025
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Apr 23, 2025
gopherbot pushed a commit that referenced this issue Apr 29, 2025
@dr2chase @cagedmantis
[release-branch.go1.24] cmd/compile: remove no-longer-necessary recur…
06fd2f1 
…sive inlining checks

this does result in a little bit more inlining,
cmd/compile text is 0.5% larger,
bent-benchmark text geomeans grow by only 0.02%.
some of our tests make assumptions about inlining.

Fixes: #73440.

Change-Id: I999d1798aca5dc64a1928bd434258a61e702951a
Reviewed-on: https://go-review.googlesource.com/c/go/+/655157
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/666555
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
@gopherbot
Copy link
Contributor Author

Closed by merging CL 666555 (commit 06fd2f1) to release-branch.go1.24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dr2chase dr2chase

Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Projects
None yet
Milestone
Go1.24.3
Development

No branches or pull requests
3 participants
@dr2chase @gopherbot @JunyangShao