-
Notifications
You must be signed in to change notification settings - Fork 18k
testing: add Output #71575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
testing: add Output #71575
Conversation
This PR (HEAD: 59f309a) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/646956. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
Message from Arati: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
Message from Arati: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
Message from Jonathan Amsterdam: Patch Set 2: Commit-Queue+1 Hold+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-02-05T20:51:24Z","revision":"7e0a540201f0c62c2e98497ff9f853a2cfef293a"} Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
Message from Jonathan Amsterdam: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
Message from Go LUCI: Patch Set 2: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-arm64-boringcrypto has failed with summary (view all results):
Build or test failure, click here for results. To reproduce, try Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
Message from Jonathan Amsterdam: Patch Set 2: Commit-Queue+1 (9 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-02-05T21:19:36Z","revision":"7e0a540201f0c62c2e98497ff9f853a2cfef293a"} Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
Message from Jonathan Amsterdam: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
Message from Go LUCI: Patch Set 2: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-arm64 has failed with summary (view all results):
Build or test failure, click here for results. To reproduce, try Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
Message from Jonathan Amsterdam: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
Message from Jonathan Amsterdam: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
This PR (HEAD: 8a61785) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/646956. Important tips:
|
Message from Arati: Patch Set 3: (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
Message from Jonathan Amsterdam: Patch Set 3: Hold+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
This PR (HEAD: 6fb1d3f) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/646956. Important tips:
|
Message from Arati: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
Message from Jonathan Amsterdam: Patch Set 4: Hold+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
This PR (HEAD: 664f85f) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/646956. Important tips:
|
Message from Arati: Patch Set 5: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
This PR (HEAD: abff258) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/646956. Important tips:
|
Message from Arati: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
Message from Jonathan Amsterdam: Patch Set 6: Hold+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
Message from Arati: Patch Set 6: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
This PR (HEAD: 9352f78) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/646956. Important tips:
|
Message from Arati: Patch Set 7: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
Message from Jonathan Amsterdam: Patch Set 7: Hold+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
Message from Arati: Patch Set 20: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
This PR (HEAD: afa16e4) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/646956. Important tips:
|
Message from Jonathan Amsterdam: Patch Set 21: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
This PR (HEAD: d8ebbea) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/646956. Important tips:
|
This PR (HEAD: f9bd701) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/646956. Important tips:
|
Message from Arati: Patch Set 23: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
Message from Alan Donovan: Patch Set 23: (11 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
Message from Jonathan Amsterdam: Patch Set 23: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
Message from Jonathan Amsterdam: Patch Set 23: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
This PR (HEAD: 6818a54) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/646956. Important tips:
|
Message from Arati: Patch Set 24: (10 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
This PR (HEAD: 29df600) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/646956. Important tips:
|
This PR (HEAD: 3a0cc20) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/646956. Important tips:
|
This PR (HEAD: 6ea1cd0) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/646956. Important tips:
|
Message from Arati: Patch Set 28: (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
Message from Alan Donovan: Patch Set 28: (6 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
Message from Jonathan Amsterdam: Patch Set 28: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
Output is a method on T, B and F. It provides an io.Writer that writes
to the same test output stream as TB.Log. The new output writer is
used to refactor the implementation of Log. It maintains the formatting
provided by Log while making call site information optional.
Additionally, it provides buffering of log messages.
Co-authored-by: Aleks Fazlieva britishrum@users.noreply.github.com
For #59928.