Skip to content

sumdb/tlog: fuzz tests for parsers #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

hickford
Copy link
Contributor

@hickford hickford commented Feb 22, 2023

Future fuzz tests could test round trip properties

@gopherbot
Copy link
Contributor

This PR (HEAD: 54148b5) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mod/+/470155 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/470155.
After addressing review feedback, remember to publish your drafts!

@hickford hickford changed the title Add fuzz tests for ParseNote and ParseTree sumdb/tlog: fuzz tests for ParseNote and ParseTree Feb 22, 2023
@hickford hickford marked this pull request as ready for review February 22, 2023 14:14
@gopherbot
Copy link
Contributor

This PR (HEAD: 0a033fb) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mod/+/470155 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Matthew Hickford:

Patch Set 2: Run-TryBot+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/470155.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/470155.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 2: TryBot-Result+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/470155.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 6443667) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mod/+/470155 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Matthew Hickford:

Patch Set 3: Run-TryBot+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/470155.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/470155.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 3: TryBot-Result+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/470155.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan Mills:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/470155.
After addressing review feedback, remember to publish your drafts!

@hickford hickford changed the title sumdb/tlog: fuzz tests for ParseNote and ParseTree sumdb/tlog: fuzz tests for parsers Feb 23, 2023
@gopherbot
Copy link
Contributor

This PR (HEAD: 6fff4e6) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mod/+/470155 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Matthew Hickford:

Patch Set 4: Run-TryBot+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/470155.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 4:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/470155.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 4: TryBot-Result+1

Copied votes on follow-up patch sets have been updated:

  • TryBot-Result+1 has been copied to patch set 5 (copy condition: "changekind:NO_CODE_CHANGE").

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/470155.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Matthew Hickford:

Patch Set 5: Run-TryBot+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/470155.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Matthew Hickford:

Patch Set 5: Code-Review+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/470155.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Feb 27, 2023
Future fuzz tests could test round trip properties

Change-Id: If195b82998ebedaeca68a7723c2558369e68f716
GitHub-Last-Rev: 6fff4e6
GitHub-Pull-Request: #18
Reviewed-on: https://go-review.googlesource.com/c/mod/+/470155
Run-TryBot: Matthew Hickford <hickford@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Matthew Hickford <hickford@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
@gopherbot
Copy link
Contributor

Message from Bryan Mills:

Patch Set 5: Auto-Submit+1 Code-Review+2 Run-TryBot+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/470155.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/470155 has been merged.

@gopherbot gopherbot closed this Feb 27, 2023
kailee55n added a commit to kailee55n/go_mod that referenced this pull request May 8, 2025
Future fuzz tests could test round trip properties

Change-Id: If195b82998ebedaeca68a7723c2558369e68f716
GitHub-Last-Rev: 6fff4e678380610ecb5f34e494cec04a9a462f62
GitHub-Pull-Request: golang/mod#18
Reviewed-on: https://go-review.googlesource.com/c/mod/+/470155
Run-TryBot: Matthew Hickford <hickford@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Matthew Hickford <hickford@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants