-
Notifications
You must be signed in to change notification settings - Fork 1.2k
http2: add IdleConnTimeout to http2.Transport #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Exposes an IdleConnTimeout on http2.Transport directly, rather than rely on configuring it through the underlying http1 transport. For golang/go#57893
This PR (HEAD: 24d1c42) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/net/+/497195 to see it. Tip: You can toggle comments from me using the |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/497195. |
Message from Damien Neil: Patch Set 1: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/497195. |
Message from David Bell: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/497195. |
This PR (HEAD: cc8f171) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/net/+/497195. Important tips:
|
Message from Damien Neil: Patch Set 2: Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/497195. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2023-09-05T21:21:40Z","revision":"e83fb9e3079e78ec9e559d7ce4de6d195d0e052b"} Please don’t reply on this GitHub thread. Visit golang.org/cl/497195. |
Message from Damien Neil: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/497195. |
Message from Damien Neil: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/497195. |
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/497195. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/497195. |
Message from Matthew Dempsky: Patch Set 2: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/497195. |
Exposes an IdleConnTimeout on http2.Transport directly, rather than rely on configuring it through the underlying http1 transport. For golang/go#57893 Change-Id: Ibe506da39e314aebec1cd6df64937982182a37ca GitHub-Last-Rev: cc8f171 GitHub-Pull-Request: #173 Reviewed-on: https://go-review.googlesource.com/c/net/+/497195 Reviewed-by: Damien Neil <dneil@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Matthew Dempsky <mdempsky@google.com>
This PR is being closed because golang.org/cl/497195 has been merged. |
Exposes an IdleConnTimeout on http2.Transport directly, rather than rely on configuring it through the underlying http1 transport.
For golang/go#57893