Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/text
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1bdb400
Choose a base ref
...
head repository: golang/text
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c8236a6
Choose a head ref
  • 2 commits
  • 4 files changed
  • 2 contributors

Commits on Nov 9, 2022

  1. all: remove redundant type conversion

    Change-Id: Ie059c983bcb3cd6bce7b2097720cbee899abf771
    GitHub-Last-Rev: ce45699
    GitHub-Pull-Request: #33
    Reviewed-on: https://go-review.googlesource.com/c/text/+/429059
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Reviewed-by: Michael Knyszek <mknyszek@google.com>
    Run-TryBot: Cherry Mui <cherryyz@google.com>
    Reviewed-by: Cherry Mui <cherryyz@google.com>
    cuishuang authored and cherrymui committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    ada7473 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2022

  1. unicode/bidi: remove unused global

    It seems like controlToClass variable is not used anymore.
    As it allocates in init we should remove it.
    Before:
    init golang.org/x/text/unicode/bidi @0.70 ms, 0.003 ms clock, 272 bytes, 2 allocs
    After:
    init golang.org/x/text/unicode/bidi @0.79 ms, 0 ms clock, 0 bytes, 0 allocs
    
    Change-Id: I79b236feb841c45908431cdb440bd1f4eb082d00
    Reviewed-on: https://go-review.googlesource.com/c/text/+/449595
    Run-TryBot: Ian Lance Taylor <iant@golang.org>
    Auto-Submit: Ian Lance Taylor <iant@google.com>
    Reviewed-by: Michael Knyszek <mknyszek@google.com>
    Run-TryBot: Ian Lance Taylor <iant@google.com>
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Thorleon authored and gopherbot committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    c8236a6 View commit details
    Browse the repository at this point in the history
Loading