sys/cpuset.h must be included after sys/param.h (FreeBSD) #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before sys/cpuset.h. This was fixed in May of 2020 (bac1f23) and undone in August of 2020 (9490b14). Here's a log showing the compile errors under FreeBSD 14.0-CURRENT: http://beefy18.nyi.freebsd.org/data/main-amd64-default/pf44e1c1de734_s63ca9ea4f3/logs/zeek-4.0.3.log Fix the order again. While we're here add a comment and disable clang-format for these includes. Thanks to @skand888 for analyzing the FreeBSD build failure which brought me here.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
jan-wassenberg
approved these changes
Jul 13, 2021
|
Thanks for fixing this permanently, clang-format reordering of headers is dangerous |
leres
added a commit
to leres/highwayhash
that referenced
this pull request
Jul 20, 2021
According to the sysctl(3) man page, sys/types.h must be included before sys/sysctl.h. This is another casualty of the August of 2020 (9490b14) autoformatter update. Here's the compile error (powerpc64*) from the commit that patched the FreeBSD security/zeek port: In file included from /wrkdirs/usr/ports/security/zeek/work/zeek-4.0.3/auxil/highwayhash/highwayhash/arch_specific.cc:27: /usr/include/sys/sysctl.h:1185:25: error: unknown type name 'u_int' int sysctl(const int *, u_int, void *, size_t *, const void *, size_t); As with google#99, add a comment and disable clang-format for these includes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the cpuset(2) man page, sys/param.h must be included before sys/cpuset.h. This was fixed in May of 2020 (bac1f23) and undone in August of 2020 (9490b14).
Here's a log showing the compile errors under FreeBSD 14.0-CURRENT:
Fix the order again. While we're here add a comment and disable clang-format for these includes.
Thanks to @skand888 for analyzing the FreeBSD build failure which brought me here.