Skip to content

Fix operator conversion. #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Fix operator conversion. #419

merged 1 commit into from
Jul 3, 2024

Conversation

MarkDaoust
Copy link
Collaborator

@MarkDaoust MarkDaoust commented Jul 1, 2024

Fixes: #411

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:python sdk Issue/PR related to Python SDK labels Jul 1, 2024
@PandasPirate
Copy link
Contributor

this can break someone's code if they are using 5 for NOT_EQUAL and 6 for EXCLUDES as per the last code. I may be wrong.

@MarkDaoust
Copy link
Collaborator Author

Normally yes, you wouldn't change enum values. But this PR fixes it so the integer values match how the API interprets them. It's possible this breaks someone, but this code has low usage (We've never provided an example of how to use this yet). I don't want to keep it out of sync with the API just for consistency with an old version. Right now if you serialize an proto that includes one of these enum values, then convert the json back to a proto the result will be different.

@shilpakancharla shilpakancharla merged commit 63a15fe into main Jul 3, 2024
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Jul 3, 2024
@MarkDaoust MarkDaoust deleted the MarkDaoust-patch-25 branch October 3, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:python sdk Issue/PR related to Python SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_OPERATOR dict with multiple 6 mentioned multiple times
3 participants