Skip to content

Update deps to Node 20 #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Update deps to Node 20 #393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/cleanup.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
runs-on: 'ubuntu-latest'

steps:
- uses: 'actions/checkout@v3'
- uses: 'actions/checkout@v4'

- uses: 'google-github-actions/auth@main'
with:
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ jobs:
id-token: 'write'
runs-on: 'ubuntu-latest'
steps:
- uses: 'actions/checkout@v3'
- uses: 'actions/checkout@v4'

- uses: 'actions/setup-node@v3'
- uses: 'actions/setup-node@v4'
with:
node-version: '16.x'
node-version: '20.x'

- name: 'npm build'
run: 'npm ci && npm run build'
Expand All @@ -51,11 +51,11 @@ jobs:
id-token: 'write'
runs-on: 'ubuntu-latest'
steps:
- uses: 'actions/checkout@v3'
- uses: 'actions/checkout@v4'

- uses: 'actions/setup-node@v3'
- uses: 'actions/setup-node@v4'
with:
node-version: '16.x'
node-version: '20.x'

- name: 'npm build'
run: 'npm ci && npm run build'
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/unit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@ jobs:
runs-on: '${{ matrix.os }}'

steps:
- uses: 'actions/checkout@v3'
- uses: 'actions/checkout@v4'

- uses: 'actions/setup-node@v3'
- uses: 'actions/setup-node@v4'
with:
node-version: '16.x'
node-version: '20.x'

- name: 'npm build'
run: 'npm ci && npm run build'
Expand Down
14 changes: 7 additions & 7 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
id-token: 'write'

steps:
- uses: 'actions/checkout@v3'
- uses: 'actions/checkout@v4'

- id: 'auth'
uses: 'google-github-actions/auth@v1'
Expand All @@ -48,7 +48,7 @@ jobs:
uses: 'google-github-actions/deploy-cloud-functions@v1'
with:
name: 'my-function'
runtime: 'nodejs16'
runtime: 'nodejs20'

# Example of using the output
- id: 'test'
Expand Down Expand Up @@ -196,7 +196,7 @@ automatically private services, while deploying a revision of a public

- `version`: The version of the function (e.g. `1`)

- `runtime`: The chosen runtime (e.g. `nodejs16`)
- `runtime`: The chosen runtime (e.g. `nodejs20`)

## Authorization

Expand Down Expand Up @@ -234,7 +234,7 @@ jobs:
id-token: 'write'

steps:
- uses: 'actions/checkout@v3'
- uses: 'actions/checkout@v4'

- id: 'auth'
uses: 'google-github-actions/auth@v1'
Expand All @@ -246,7 +246,7 @@ jobs:
uses: 'google-github-actions/deploy-cloud-functions@v1'
with:
name: 'my-function'
runtime: 'nodejs16'
runtime: 'nodejs20'
```

### Via Application Default Credentials
Expand All @@ -260,13 +260,13 @@ only works using a custom runner hosted on GCP.**
jobs:
job_id:
steps:
- uses: 'actions/checkout@v3'
- uses: 'actions/checkout@v4'

- id: 'deploy'
uses: 'google-github-actions/deploy-cloud-functions@v1'
with:
name: 'my-function'
runtime: 'nodejs16'
runtime: 'nodejs20'
```

The action will automatically detect and use the Application Default
Expand Down
2 changes: 1 addition & 1 deletion action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,5 +241,5 @@ branding:
color: 'blue'

runs:
using: 'node16'
using: 'node20'
main: 'dist/index.js'
24 changes: 13 additions & 11 deletions dist/index.js
View file
Open in desktop

Large diffs are not rendered by default.

Loading