Skip to content

React 18 in peer-dependencies and use new API #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

derkoe
Copy link
Contributor

@derkoe derkoe commented Apr 5, 2022

Closes #1102

@alexcastrodev
Copy link

Thanks @derkoe ❤️

@mdfahadhossain
Copy link

Waiting for this change.

@SmartMan1226
Copy link

I hope this will also solve #1110

@BrandonCopley
Copy link

How can I help get this into production?

@tetarchus
Copy link

@karldanninger @itsmichaeldiego - Are you able to merge and release this PR to allow upgrading to React 18?

@dryan-FF dryan-FF mentioned this pull request Jun 2, 2022
@Gervwyk
Copy link

Gervwyk commented Jun 16, 2022

Would be great if this can be released!

@joaogarin
Copy link

Would be lovely to get this released and unblock people using the library to move to React 18 =)

@troiscodes
Copy link

Please release it 👯

@ArnaudSantucci
Copy link

ArnaudSantucci commented Jun 23, 2022

Yes plz !! release it 🥇

@itsmichaeldiego ??

@asdutoit
Copy link

??

@karldanninger karldanninger merged commit c12b94f into google-map-react:master Jul 5, 2022
@karldanninger
Copy link
Contributor

karldanninger commented Jul 5, 2022

Sorry this took so long... We need to get better at maintaining this package.
I've merged this and set a release for 2.2.

Let me know if this is enough for npm to serve this latest version.

@jacobgad
Copy link

jacobgad commented Jul 6, 2022

i don't believe this is enough for npm to serve the latest version. As you can see here:
https://www.npmjs.com/package/google-map-react

it is still serving 2.1.10

@derkoe derkoe deleted the react-18 branch July 6, 2022 06:05
@derkoe
Copy link
Contributor Author

derkoe commented Jul 6, 2022

@karldanninger somebody has to publish the package manually since there are no CI jobs setup (the last version was published by @itsmichaeldiego)

@karldanninger
Copy link
Contributor

I've contacted @itsmichaeldiego, will try to get this expedited.

@itsmichaeldiego
Copy link
Member

itsmichaeldiego commented Jul 6, 2022

Done @karldanninger @derkoe. Let me know!

@asdutoit
Copy link

asdutoit commented Jul 7, 2022

Many thanks!

@itsmichaeldiego
Copy link
Member

@derkoe @karldanninger @dryan-FF Seems that there's an issue still #1129 (comment), could you guys check it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React 18 Support