-
Notifications
You must be signed in to change notification settings - Fork 855
Init markersDispatcher_ on componentDidMount #1146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks, @bordeo for the initiative |
|
I'm sorry, but I tried to use your fork in my project, and it doesn't solve the issue of having the markers jump... (in my package.json I put |
Any rough estimate as to when this can get merged? |
I have tried installing the fork and it does solve the issues with react 18 and i can now run the package in my React 18 library. |
Here is my trail of issues related to React 18 if it helps anyone to follow through: v2.1.10:
See https://www.loom.com/share/8a010b76a6504d11b6d6e3a6fae83b1a This PR #1146
See https://www.loom.com/share/2995f667d363417ba9fe4b4286e72aee My PR https://github.com/deliverty/google-map-react/pull/1
See https://www.loom.com/share/cb6c55ae652c4b17a8efb9924a1f0ccb For now I am settling for my PR and without StrictMode. |
Hello! |
Merged and published in version: 2.2.1, please let me know if it works for you, thanks! |
@itsmichaeldiego did you tried it before merging it? |
@giorgiabosello That issue is not related to this version! We don't use that map example anymore! |
@itsmichaeldiego same 😅 |
Due to React Strict Mode updates
markersDispatcher_
needs to be initialized oncomponentDidMount
This pull request fixes: